Skip to content

Commit

Permalink
fix comments 2
Browse files Browse the repository at this point in the history
  • Loading branch information
R-JunmingChen committed Aug 30, 2023
1 parent e2aa28a commit cfbb4ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cpp/src/arrow/compute/api_scalar.h
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ class ARROW_EXPORT SetLookupOptions : public FunctionOptions {
enum NullMatchingBehavior { MATCH, SKIP, EMIT_NULL, INCONCLUSIVE };

explicit SetLookupOptions(Datum value_set, NullMatchingBehavior = MATCH);
// DEPRECATED(will be removed after removing of skip_nulls)
ARROW_DEPRECATED("will be removed after removing of skip_nulls")
explicit SetLookupOptions(Datum value_set, bool skip_nulls);
SetLookupOptions();
static constexpr char const kTypeName[] = "SetLookupOptions";
Expand All @@ -294,16 +294,16 @@ class ARROW_EXPORT SetLookupOptions : public FunctionOptions {
/// (IndexIn and IsIn) in the output.
NullMatchingBehavior null_matching_behavior;

// DEPRECATED(will be removed after removing of skip_nulls)
ARROW_DEPRECATED("will be removed after removing of skip_nulls")
NullMatchingBehavior GetNullMatchingBehavior() const;

// DEPRECATED(use null_matching_behavior instead)
/// Whether nulls in `value_set` count for lookup.
///
/// If true, any null in `value_set` is ignored and nulls in the input
/// produce null (IndexIn) or false (IsIn) values in the output.
/// If false, any null in `value_set` is successfully matched in
/// the input.
ARROW_DEPRECATED("use null_matching_behavior instead")
std::optional<bool> skip_nulls;
};

Expand Down
2 changes: 1 addition & 1 deletion python/pyarrow/_compute.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -2325,7 +2325,7 @@ cdef class Expression(_Weakrefable):
1,
2,
3
], skip_nulls=0, null_matching_behavior=MATCH})>
], skip_nulls=0, null_matching_behavior=<INVALID>})>
"""

def __init__(self):
Expand Down

0 comments on commit cfbb4ce

Please sign in to comment.