[FEAT] Co-op #210

xamionex · 2022-02-14T09:10:10Z

death and more

Coop_LoadMapFromStartPoint allows loading from beginning of map

Added util function for loading maps

Load sp_crashsite

…o co-op

Adds a function for iterating over playlist

abarichello · 2022-02-15T16:47:30Z

Closes #207

catornot · 2022-09-23T00:47:51Z

can someone review co-op?

uniboi · 2022-09-23T07:10:17Z

Northstar.Coop/mod/scripts/vscripts/_respawns.nut

+    player.s.inPostDeath = false
+    player.s.respawnSelectionDone = true
+    DoRespawnPlayer( player, null )
+    ClientCommand( player,"script_client thread MainHud_TurnOn_RUI( true )" ) // TODO: can this help with no hud on dedi?


Didn't clientcommands get yeeted?

Can't test rn, but this should no longer work on latest

this might be the reason for the broken ui on dedi servers :(

F1F7Y · 2022-09-23T08:06:48Z

Also could you maybe tell us what you changed in the *.ent files ?

uniboi · 2022-09-23T09:01:32Z

Also could you maybe tell us what you changed in the *.ent files ?

I think it would be easier for you to extract the vpks yourself and show the diffs with your text editor of choice

F1F7Y · 2022-09-23T09:15:06Z

Also could you maybe tell us what you changed in the *.ent files ?

I think it would be easier for you to extract the vpks yourself and show the diffs with your text editor of choice

I asked because I dont have access to the game rn :(

catornot · 2022-09-23T16:39:04Z

in s2s's ent file I added a stuff to spawn a third a widow ship, which serves the role of a respawn point.
in crashsite's ent file I removed a rock that blocked off slow fast people

uniboi

some things I noticed after a quick look

Northstar.Coop/mod.json

uniboi · 2022-10-02T08:38:35Z

Northstar.Coop/mod/scripts/vscripts/_respawns.nut

+	// massive trol
+	for( int x = 1; x < achievements.MAX_ACHIVEMENTS; x++ )
+		UnlockAchievement( player, x )


cring

Suggested change

// massive trol

for( int x = 1; x < achievements.MAX_ACHIVEMENTS; x++ )

UnlockAchievement( player, x )

I removed it, In a commit that I didn't push yet

Northstar.Coop/mod/scripts/vscripts/_respawns.nut

uniboi · 2022-10-02T08:42:21Z

Northstar.Coop/mod/scripts/vscripts/_respawns.nut

+
+    wait 1
+
+    for(;;)


why is this loop infinite?

people sometimes can't be respawned right away.

uniboi · 2022-10-02T08:44:29Z

Northstar.Coop/mod/scripts/vscripts/_respawns.nut

+        foreach( p in GetPlayerArray() )
+        {
+            if ( IsValid( p ) && IsAlive( p ) && p != player && p.IsOnGround() && !p.IsWallRunning() && !p.IsWallHanging() )
+            {
+                    BasicRespawnLogic( player )
+                    player.SetOrigin( p.GetOrigin() )
+
+                    if ( p.IsTitan() )
+                        thread MakePlayerTitan( player, p.GetOrigin() )
+
+                    OnTimeShiftGiveGlove( player )
+					if ( ( GetMapName() == "sp_beacon" || GetMapName() == "sp_beacon_spoke0" ) && Flag( "HasChargeTool" ) )
+						GiveBatteryChargeToolSingle( player )
+
+					player.Signal( "InternalPlayerRespawned" )
+            }


assuming there are 3 players on a server and one dies, this would set the position of the respawning player twice. Why not break after a valid player where you can respawn is found?

it wouldn't set twice.
after the player receives the signal InternalPlayerRespawned the thread is over

well unless the needs to be respawned as a titan.
that's just how I coded it.

Northstar.Coop/mod/scripts/vscripts/bt_genocide.nut

uniboi · 2022-10-02T08:59:19Z

Northstar.Coop/mod/scripts/vscripts/client/cl_respawnselect_sp.gnut

+
+void function ClRespawnselect_SP_Init()
+{
+	Assert( !IsMultiplayer() )


pretty sure this is never supposed to happen in coop. Just remove the function?

thats how respawn did it

uniboi · 2022-10-02T09:00:24Z

Northstar.Coop/mod/scripts/vscripts/sh_coop_custom_precache.gnut

+
+void function CoopCustomPrecache()
+{
+	// PrecacheWeapon( "mp_weapon_peacekraber" )


I don't see an issue with loading the peacekraber

Suggested change

// PrecacheWeapon( "mp_weapon_peacekraber" )

PrecacheWeapon( "mp_weapon_peacekraber" )

the peacekraber pr hasn't been merged yet :(
#398

uniboi · 2022-10-02T09:01:19Z

Northstar.Coop/mod/scripts/vscripts/sh_coop_custom_precache.gnut

+	// create kunai damage source so game won't crash when we hit smth with it
+	// just using the default melee one, easier than making a new one
+	getconsttable()[ "eDamageSourceId" ][ "melee_pilot_kunai" ] <- eDamageSourceId.melee_pilot_emptyhanded


make a new one https://r2northstar.readthedocs.io/en/latest/reference/northstar/customdamagesources.html

uniboi · 2022-10-02T09:04:58Z

Northstar.Coop/mod/scripts/vscripts/sp/sp_sewer_common.nut

+				try{
+				player.StopSoundOnEntity( geigerSFX_1 )
+				player.StopSoundOnEntity( geigerSFX_2 )
+				player.StopSoundOnEntity( geigerSFX_3 )
+				}
+				catch( aaaaaaaaa )
+				{
+					print( aaaaaaaaa )
+				}


what's the error here?

it works so I wouldn't want to touch it.

uniboi · 2022-10-05T11:04:22Z

Northstar.Coop/mod/scripts/vscripts/sp/sh_sp_credits.nut

+struct MyFile
+{
+	entity camera
+	vector skycam_origin
+	vector skycam_angles
+}
+MyFile file


me when respawn devs don't even bother renaming copy pasted code

uniboi · 2022-10-05T11:07:04Z

Northstar.Coop/mod/scripts/vscripts/sp/sh_sp_credits.nut

+void function EmptyFunc()
+{
+
+}


Why is respawn like this

😅
I did that

Northstar.Coop/mod/scripts/vscripts/sp/hubs/sp_beacon_ending.nut

uniboi · 2022-11-03T19:30:56Z

I made a quick script that helps to compare coop changes to vanilla scripts.

Windows

mkdir cdiffs
cd cdiffs
git clone https://github.com/xamionex/NorthstarMods -b co-op
git clone https://gist.github.com/uniboi/8dda378adc18aeeb11892abe66e3774f
curl https://salzgrube.club/static/assets_dump.zip -o assets_dump.zip
powershell -command "Expand-Archive -Force './assets_dump.zip' '.'"
py 8dda378adc18aeeb11892abe66e3774f/create_diff_folder.py

Linux

mkdir cdiffs
cd cdiffs
git clone https://github.com/xamionex/NorthstarMods -b co-op
wget salzgrube.club/static/assets_dump.zip
unzip assets_dump.zip
git clone https://gist.github.com/uniboi/8dda378adc18aeeb11892abe66e3774f
python3 ./8dda378adc18aeeb11892abe66e3774f/create_diff_folder.py

VSCode has a compare function built in. Simply select select for compare on the vanilla file and compare with selected on the coop file.

DxsSucuk · 2022-12-27T16:03:03Z

Is there any update related to this PR?

DxsSucuk · 2023-01-26T20:17:35Z

I made a docker image based on pg9182 Dedicated Server.
You can check out the Fork here and the docker Image link is here ghcr.io/dxssucuk/northstar-dedicated-dev:dev.20230119.git8ba3d73

Also there is a packed Northstar instance with the coop mod here

xamionex added 3 commits February 14, 2022 09:17

add wolf's code

bef38c0

add convar so we dont crash and change version

4e29ab4

add 2 convars for training mission.

56f1110

xamionex and others added 23 commits February 14, 2022 10:19

upload default sp_training.nut

1313674

add northstar.coop

2ccb802

Added util function for loading maps

dad3bc4

Coop_LoadMapFromStartPoint allows loading from beginning of map

Merge pull request #2 from H0L0theBard/co-op

3580b7c

Added util function for loading maps

Load sp_crashsite

821ea5c

not used

10a2f9a

swap out map change

4115824

Merge pull request #4 from H0L0theBard/co-op

a01672e

Load sp_crashsite

add admin commands (ty karma)

191046f

remove vars and add admin cmds

133154d

resolve conflict

ce8c28c

remove admin abus

4692a1a

Merge branch 'R2Northstar:main' into co-op

671a6be

bring back convars into mod.json

ada1528

Merge branch 'co-op' of https://github.com/xamionex/NorthstarMods int…

4ff9be0

…o co-op

Added _start_points.gnut from the sp vpks

0c2ebdd

Added support for multiple players to transition level

9cfa807

Merge branch 'R2Northstar:main' into co-op

04bbb20

Merge branch 'R2Northstar:main' into co-op

7eb0801

add default introscreen

3ded7ee

Merge branch 'co-op' of https://github.com/xamionex/NorthstarMods int…

4c467bc

…o co-op

Adds a function for iterating over playlist

d58e6ad

Merge pull request #6 from H0L0theBard/co-op

aee8a44

Adds a function for iterating over playlist

xamionex mentioned this pull request Feb 15, 2022

Co-Op crashes #207

Open

8 tasks

abarichello linked an issue Feb 15, 2022 that may be closed by this pull request

Co-Op crashes #207

Open

8 tasks

catornot added 11 commits August 9, 2022 23:45

fixing stuff

096376a

fixing crashsite :)

8894b77

adding boomtown scripts

b0008d1

adding _utility_sp.gnut

b281ed5

adding fr _utility_sp.gnut

f23e1c1

fixes + adding beacon stuff

168c2e9

fixing beacon

c07c95b

adding the sp level files

e9c9b54

FIXINGAaaaaaaaaaaaaaaaaaaaaaaaaaaa

f05998d

fixing some stuff :D

8454fed

fixed sp_skyway_v1

6e117b1

uniboi reviewed Sep 23, 2022

View reviewed changes

fixing stuff

bb82641

uniboi requested changes Oct 2, 2022

View reviewed changes

uniboi reviewed Oct 5, 2022

View reviewed changes

uniboi reviewed Oct 10, 2022

View reviewed changes

Northstar.Coop/mod/scripts/vscripts/sp/hubs/sp_beacon_ending.nut Show resolved Hide resolved

catornot added 3 commits October 10, 2022 21:27

suggetsion and stuff I forgor

9a26865

suggetsions 2

f115ba5

re-enable mobility ghots (they work now)

0e19526

dump changes

29dd48c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Co-op #210

[FEAT] Co-op #210

xamionex commented Feb 14, 2022

abarichello commented Feb 15, 2022

catornot commented Sep 23, 2022 •

edited

Loading

uniboi Sep 23, 2022

F1F7Y Sep 23, 2022

catornot Jan 17, 2023

F1F7Y commented Sep 23, 2022

uniboi commented Sep 23, 2022

F1F7Y commented Sep 23, 2022

catornot commented Sep 23, 2022

uniboi left a comment

uniboi Oct 2, 2022

catornot Oct 2, 2022

uniboi Oct 2, 2022

catornot Oct 3, 2022

uniboi Oct 2, 2022

catornot Oct 2, 2022

uniboi Oct 2, 2022

catornot Oct 2, 2022

uniboi Oct 2, 2022

catornot Oct 2, 2022

uniboi Oct 2, 2022

uniboi Oct 2, 2022

catornot Oct 2, 2022

catornot Oct 4, 2022

uniboi Oct 5, 2022

uniboi Oct 5, 2022

catornot Oct 6, 2022

uniboi commented Nov 3, 2022 •

edited

Loading

DxsSucuk commented Dec 27, 2022

DxsSucuk commented Jan 26, 2023 •

edited

Loading

	// massive trol
	for( int x = 1; x < achievements.MAX_ACHIVEMENTS; x++ )
	UnlockAchievement( player, x )

	// PrecacheWeapon( "mp_weapon_peacekraber" )
	PrecacheWeapon( "mp_weapon_peacekraber" )

[FEAT] Co-op #210

Are you sure you want to change the base?

[FEAT] Co-op #210

Conversation

xamionex commented Feb 14, 2022

abarichello commented Feb 15, 2022

catornot commented Sep 23, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

F1F7Y commented Sep 23, 2022

uniboi commented Sep 23, 2022

F1F7Y commented Sep 23, 2022

catornot commented Sep 23, 2022

uniboi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uniboi commented Nov 3, 2022 • edited Loading

Windows

Linux

DxsSucuk commented Dec 27, 2022

DxsSucuk commented Jan 26, 2023 • edited Loading

catornot commented Sep 23, 2022 •

edited

Loading

uniboi commented Nov 3, 2022 •

edited

Loading

DxsSucuk commented Jan 26, 2023 •

edited

Loading