-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Reorganize workflows #29
Merged
GeckoEidechse
merged 10 commits into
R2Northstar:master
from
Alystrasz:build/reorganize-workflows
Jan 29, 2024
Merged
ci: Reorganize workflows #29
GeckoEidechse
merged 10 commits into
R2Northstar:master
from
Alystrasz:build/reorganize-workflows
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifiedMods into build/reorganize-workflows
GeckoEidechse
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially, this PR just moves workflow steps around into different files without changing the logic (a few names or comments have been updated but that's it)
Not sure if the extra verified-mods.yml
is really necessary but overall this is already an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
META PR, NO MOD VERIFICATION NEEDED
This PR separates CI workflows in two different flows: one dedicated to manifest verification, the other to mods verification.
The idea is to avoid running mods verification if manifesto checking fails.
Before PR
After PR