Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0 #310

Merged
merged 119 commits into from
Aug 29, 2018
Merged

Release 0.5.0 #310

merged 119 commits into from
Aug 29, 2018

Conversation

nivemaham
Copy link
Collaborator

@nivemaham nivemaham commented Aug 16, 2018

Changes from release 0.4.1

MetaQR code #275

Exception Harmonization #294

  • We have new exceptions based on HTTP Status code conventions and a ExceptionTranslator to implement body and headers.

Other fixes

Closes #275, closes #289, closes #291, closes #292, closes #294, closes #297, closes #299, closes #301, closes #304, closes #308, closes #311, closes #313, closes #317.

Copy link
Contributor

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With RADAR-base/RADAR-Docker#154, the sleep in the meta-qr code may not be needed at all. It should then still be documented in the readme that the at code should definitely be rate limited by upstream web servers.

It would still be good to document/modify the description in README.md of how OAuth2.0 clients should integrate with MP using the Meta-QR code

blootsvoets
blootsvoets previously approved these changes Aug 23, 2018
Copy link
Contributor

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment