Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate - reinventing our html pipeline #151

Closed
wants to merge 14 commits into from
Closed

Regenerate - reinventing our html pipeline #151

wants to merge 14 commits into from

Conversation

hlageek
Copy link
Contributor

@hlageek hlageek commented Jan 12, 2025

Fundamental backend changes:

  • new streamlined, efficient, and accurate algorithm for overlap calculation
  • displayed text constructor refactored to output shiny.taglist class

Related to #34
Fixes a bug where segments in the length of 1 character were not displayed in annotation screen

@hlageek hlageek requested a review from skvrnami January 13, 2025 09:33
@hlageek hlageek self-assigned this Jan 13, 2025
@hlageek
Copy link
Contributor Author

hlageek commented Jan 13, 2025

I actually experience a quite noticeable performance degradation, compared to previous implementation, as documents increase in length (number of lines). However, I think we still need to prioritize accuracy and cleanliness over speed in this case.

@hlageek
Copy link
Contributor Author

hlageek commented Jan 19, 2025

We'll try something else

@hlageek hlageek closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant