You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Will leave to see if others want to review, then let it merge up later today. I couldn't find where materialize.png was referenced, so that may be extra but wanted to mention in case you had something in mind for it.
quick FYI - I'm disabling our plan/apply GH actions for now. They serve as good examples, but I don't think we have reason to live-sync our feature repo(s). LMK if you'd disagree, thanks!
LGTM, thanks! Will leave to see if others want to review, then let it merge up later today. I couldn't find where materialize.png was referenced, so that may be extra but wanted to mention in case you had something in mind for it.
Thanks for review.
Removed as this was extra added.
quick FYI - I'm disabling our plan/apply GH actions for now. They serve as good examples, but I don't think we have reason to live-sync our feature repo(s). LMK if you'd disagree, thanks!
Totally agree as like this example we are not using AWS or other cloud provider. For the time good to remove.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redhatHameed
force-pushed
the
postgres
branch
from
Added an example for using PostgreSQL as a database registry for Feast