Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add GCP provider to floorist #717

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

avitova
Copy link
Member

@avitova avitova commented Oct 13, 2023

I noticed we do not make statistics of gcp provider. 👀 I understand that the floorplan is old, but I hope we can do this now.
Please, do not merge yet, I am thinking if I would add something else. But could you please check if this would not break the process?

note: We only track whether or not the users use any template, but we do not track what is in the template. We could add the template to the floorplan in the future, but we'd most likely have to export the template for each reservation detail. I remember @lzap wanted to track this, so I am just saying it is possible. But it seems it would complicate the data, so I would postpone it a bit.

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that is a huge overlook, I should have added it. :-(

I suggest to merge this, you can do a followup if you want additional fields. Template is definitely a good column to have, I think a boolean can be a good start (to know if customers actually use the feature or not).

@lzap
Copy link
Member

lzap commented Oct 16, 2023

Also I noticed we do union of three sorted results, not sure how useful is sorting this way. We can probably remove sorting alltogether.

@avitova
Copy link
Member Author

avitova commented Oct 16, 2023

Yeah, true. There is probably no need to sort these. 👍 I also noticed just now, as I found it weird there is no data yet for this provider. But that is okay, we will see even the old ones, once this is merged and we get the data. 👍 You are right, let's merge now, and add more later. :)

@avitova
Copy link
Member Author

avitova commented Oct 16, 2023

/retest

We could also sort it on top of all that if we find the need to do that. But I personally do not need that for the statistics, so I think we are good.

@ezr-ondrej
Copy link
Member

ezr-ondrej commented Oct 16, 2023

The tests are broken, I'm working on a fix, but those tests do not test floorist anyway, so lets just merge :)

@ezr-ondrej ezr-ondrej merged commit c806fe9 into RHEnVision:main Oct 16, 2023
6 checks passed
@avitova
Copy link
Member Author

avitova commented Oct 16, 2023

Thank you:)

@vkrizan
Copy link

vkrizan commented Oct 23, 2023

Hey,
I think that these changes could be the reason why your floorist pipeline is failing:

psycopg2.errors.SyntaxError: each UNION query must have the same number of columns
LINE 5: (select 'gcp' as provider, r.id, r.creat...
^

@ezr-ondrej
Copy link
Member

ezr-ondrej commented Oct 23, 2023

Thanks a bunch @vkrizan ! 🧡
We've already fixed it in #728 but we did not want to release end of the week, so it only got to prod today, hopefully it should be fixed today's run :)

EDIT: I'm not really sure which PR was the actuall fix, but it works in stage, so today's push should fix it anyway xD

@avitova
Copy link
Member Author

avitova commented Oct 24, 2023

Thank you, @vkrizan, you are right.
This one was the actual fix, gcp had less columns than the rest of the providers. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants