-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add GCP provider to floorist #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that is a huge overlook, I should have added it. :-(
I suggest to merge this, you can do a followup if you want additional fields. Template is definitely a good column to have, I think a boolean can be a good start (to know if customers actually use the feature or not).
Also I noticed we do union of three sorted results, not sure how useful is sorting this way. We can probably remove sorting alltogether. |
Yeah, true. There is probably no need to sort these. 👍 I also noticed just now, as I found it weird there is no data yet for this provider. But that is okay, we will see even the old ones, once this is merged and we get the data. 👍 You are right, let's merge now, and add more later. :) |
/retest We could also sort it on top of all that if we find the need to do that. But I personally do not need that for the statistics, so I think we are good. |
The tests are broken, I'm working on a fix, but those tests do not test floorist anyway, so lets just merge :) |
Thank you:) |
Hey,
|
I noticed we do not make statistics of gcp provider. 👀 I understand that the floorplan is old, but I hope we can do this now.
Please, do not merge yet, I am thinking if I would add something else. But could you please check if this would not break the process?
note: We only track whether or not the users use any template, but we do not track what is in the template. We could add the template to the floorplan in the future, but we'd most likely have to export the template for each reservation detail. I remember @lzap wanted to track this, so I am just saying it is possible. But it seems it would complicate the data, so I would postpone it a bit.