Introduce test for checking rule identifiers #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comps
requested changes
Sep 25, 2024
mildas
force-pushed
the
rule_identifiers
branch
from
4dc6f22
to
b7d01b4
Compare
mildas
force-pushed
the
rule_identifiers
branch
from
b7d01b4
to
59951a5
Compare
mildas
force-pushed
the
rule_identifiers
branch
from
fdcc546
to
8462bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for known references of individual profiles.
References are links with specific identifiers.
It's not possible to automatically check whether the identifiers are correct as those are coming from policy requirements. However, we can test if policy references are assigned to profile rules.
The references mapping could be read from CaC/content
ssg/constants.py. But as it lists references for all CaC/content profiles and products, most of that stuff would have to be filtered out and wouldn't simplify things much here. And so mapping is part of the test code.Note: do not merge yet, a lot of failures caused by missing references in various profiles. I'm going to create CaC upstream issues for each individual rhel+profile combination and create waivers.