Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect local changes in container without rebuild #248

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Reflect local changes in container without rebuild #248

merged 2 commits into from
Dec 1, 2023

Conversation

adhil0
Copy link
Collaborator

@adhil0 adhil0 commented Nov 30, 2023

  • Add volumes, flags, and env vars to docker-compose.yml so that code changes are reflected inside of the container
  • Handle "labels" and "rbac" if they aren't defined.

@adhil0 adhil0 requested a review from dcritch November 30, 2023 21:44
dcritch
dcritch approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tight!

@dcritch dcritch merged commit 7a427ca into main Dec 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcritch dcritch dcritch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhil0 @dcritch