Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding TRACK to all new cases created + fixing version of xmlsec to 1… #290

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

aluneau
Copy link
Contributor

@aluneau aluneau commented Apr 19, 2024

….3.13
I updated libtelco5g.py to update the created jira card with TRACK in the custom field corresponding to release_note_text.
I added also a fixed version for xmlsec because the application was not running with 1.3.14 so I fixed the version number to 1.3.13 in setup.py.

@adhil0
Copy link
Collaborator

adhil0 commented Apr 19, 2024

Looks like the upstream saml package we are using requires xmlsec >= 1.3.9, which explains why it upgraded the version automatically

@aluneau
Copy link
Contributor Author

aluneau commented Apr 19, 2024

Yes by default it is upgrading to 1.3.14 but with this version running podman-compose up on the dev env give this error:

podman start -a dashboard_celery-beat_1
exit code: 2
Usage: celery [OPTIONS] COMMAND [ARGS]...
Try 'celery --help' for help.

Error: Invalid value for '-A' / '--app': 
Unable to load celery application.
While trying to load the module t5gweb.taskmgr the following error occurred:
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/celery/bin/celery.py", line 58, in convert
    return find_app(value)
           ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/celery/app/utils.py", line 383, in find_app
    sym = symbol_by_name(app, imp=imp)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/kombu/utils/imports.py", line 59, in symbol_by_name
    module = imp(module_name, package=package, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/celery/utils/imports.py", line 109, in import_from_cwd
    return imp(module, package=package)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/srv/t5gweb/__init__.py", line 7, in <module>
    from . import api, t5gweb, ui
  File "/srv/t5gweb/ui.py", line 21, in <module>
    from onelogin.saml2.auth import OneLogin_Saml2_Auth
  File "/usr/local/lib/python3.12/site-packages/onelogin/saml2/auth.py", line 12, in <module>
    import xmlsec
xmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch')

Forcing version 1.3.13 avoid this

@adhil0
Copy link
Collaborator

adhil0 commented Apr 19, 2024

understood, thanks

Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the card update syntax is working for me!

@adhil0 adhil0 requested a review from dcritch April 19, 2024 22:00
Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for the PR!

will there be another PR incoming to bubble it up to the UI?

@adhil0 adhil0 merged commit 2916edd into RHsyseng:main Apr 23, 2024
2 checks passed
@aluneau
Copy link
Contributor Author

aluneau commented Apr 24, 2024

Thanks for the review !
I will discuss with the team if it would be needed to add that in the UI. For now I don't think so but it could be an idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants