Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/ztimer_mbox_get_timeout: Fix flakyness #21127

Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented Jan 10, 2025

Contribution description

On native when build with LLVM, time seems to not monotonically increase, causing a test to be flaky.

This disables the part that is flaky on native on native.

Testing procedure

make BOARD=native TOOLCHAIN=llvm -C tests/sys/ztimer_mbox_get_timeout && for i in {1..100}; do tests/sys/ztimer_mbox_get_timeout/bin/native/tests_ztimer_mbox_get_timeout.elf || break; done

This should run in this PR, but fails in master.

Issues/PRs references

Flaky test introduced in #21113

On `native` when build with LLVM, time seems to not monotonically
increase, causing a test to be flaky.

This disables the part that is flaky on native on native.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 10, 2025
@maribu maribu requested a review from benpicco January 10, 2025 21:54
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jan 10, 2025
@riot-ci
Copy link

riot-ci commented Jan 10, 2025

Murdock results

✔️ PASSED

71fa44c tests/sys/ztimer_mbox_get_timeout: Fix flakyness

Success Failures Total Runtime
23 0 23 01m:39s

Artifacts

@maribu maribu added this pull request to the merge queue Jan 12, 2025
Merged via the queue into RIOT-OS:master with commit 85a0968 Jan 12, 2025
28 checks passed
@maribu maribu deleted the tests/sys/ztimer_mbox_get_timeout/flaky branch January 12, 2025 17:56
@maribu
Copy link
Member Author

maribu commented Jan 12, 2025

Thx :-)

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants