Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix title levels #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Artoria2e5
Copy link

"Using thisthat" is under installation, so I moved these to level-2 titles. This should make it read more logical.

I don't really know how to rephrase the top so the biggest title is just one line.

@Artoria2e5
Copy link
Author

Artoria2e5 commented Dec 29, 2019

Can we... figure out a way to describe a maximum common part of the code-style of this entire repository and apply it using clang-format? This will make reading and refactoring this thing easier in the long run.

What I have so far is:

---
BasedOnStyle: WebKit
# This is usually bigger
ColumnLimit: '120'
IndentPPDirectives: BeforeHash
IndentWidth: '4'
TabWidth: '4'
UseTab: ForIndentation
SpaceAfterCStyleCast: true

# DerivePointerAlignment: true
PointerAlignmentStyle: Left

# This is not uniformly done
SpacesInParentheses: true
...

Note that IndentPPDirectives DOES detect include guards, but not in the way they current look like. You must make it look like #ifndef XXX followed by #define XXX immediately, and have it cover the entire file with no #else. In the repo the define is currently at the end, so the guards miss the detection.

@RJVB
Copy link
Owner

RJVB commented Dec 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants