Skip to content

Commit

Permalink
Update to node 20 (#77)
Browse files Browse the repository at this point in the history
  • Loading branch information
xylo04 authored Jun 11, 2024
1 parent 3ff99a5 commit a2eb384
Show file tree
Hide file tree
Showing 14 changed files with 29 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: '18'
node-version: '20'

- name: Install web dependencies
run: npm ci
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/[email protected]
with:
node-version: '18'
node-version: '20'

- name: Checkout
uses: actions/checkout@v4
Expand All @@ -28,7 +28,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/[email protected]
with:
node-version: '18'
node-version: '20'

- name: Checkout
uses: actions/checkout@v4
Expand All @@ -47,7 +47,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/[email protected]
with:
node-version: '18'
node-version: '20'

- name: Checkout
uses: actions/checkout@v4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/update-firestore.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "{Reusable} Update Firestore Test Dependencies"
name: '{Reusable} Update Firestore Test Dependencies'
on:
workflow_call:
secrets:
Expand All @@ -18,7 +18,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: "18"
node-version: '20'

- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -33,9 +33,9 @@ jobs:
- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
token: "${{ secrets.GH_PAT }}"
add-paths: "firestore/package*.json"
token: '${{ secrets.GH_PAT }}'
add-paths: 'firestore/package*.json'
commit-message: npm update (firestore)
title: npm update (firstore)
branch: update-firestore
author: "github-actions <[email protected]>"
author: 'github-actions <[email protected]>'
10 changes: 5 additions & 5 deletions .github/workflows/update-func.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "{Reusable} Update Cloud Functions dependencies"
name: '{Reusable} Update Cloud Functions dependencies'
on:
workflow_call:
secrets:
Expand All @@ -18,7 +18,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: "18"
node-version: '20'

- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -33,9 +33,9 @@ jobs:
- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
token: "${{ secrets.GH_PAT }}"
add-paths: "functions/package*.json"
token: '${{ secrets.GH_PAT }}'
add-paths: 'functions/package*.json'
commit-message: npm update (functions)
title: npm update (functions)
branch: update-functions
author: "github-actions <[email protected]>"
author: 'github-actions <[email protected]>'
14 changes: 8 additions & 6 deletions .github/workflows/update-web.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "{Reusable} Update Web dependencies"
name: '{Reusable} Update Web dependencies'
on:
workflow_call:
secrets:
Expand All @@ -24,15 +24,17 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: "18"
node-version: '20'

- name: Cache node deps
uses: actions/cache@v4
env:
cache-name: cache-web-node-deps
with:
path: ~/.npm
key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('web/package-lock.json') }}
key:
${{ runner.os }}-${{ env.cache-name }}-${{
hashFiles('web/package-lock.json') }}

- name: npm update
run: |
Expand All @@ -44,9 +46,9 @@ jobs:
- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
token: "${{ secrets.GH_PAT }}"
add-paths: "web/package*.json"
token: '${{ secrets.GH_PAT }}'
add-paths: 'web/package*.json'
commit-message: npm update (web)
title: npm update (web)
branch: update-web
author: "github-actions <[email protected]>"
author: 'github-actions <[email protected]>'
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
3 changes: 0 additions & 3 deletions data/js/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions data/js/package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
{
"name": "open-ics-data",
"type": "module",
"engines": {
"node": ">= 18.12 <19"
},
"dependencies": {
"firebase-admin": "12.0.0",
"node-xlsx": "^0.23.0",
Expand Down
2 changes: 1 addition & 1 deletion firestore/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion firestore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"test": "firebase emulators:exec --project=open-ics --only=firestore 'mocha --exit firestore.spec.js'"
},
"engines": {
"node": ">= 18"
"node": ">= 20"
},
"devDependencies": {
"@firebase/rules-unit-testing": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion functions/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"test": "npm run build && mocha --reporter spec ./build/ --recursive"
},
"engines": {
"node": "18"
"node": "20"
},
"main": "build/src/index.js",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"private": true,
"engines": {
"node": ">=18"
"node": ">=20"
},
"dependencies": {
"@angular/animations": "17.3.11",
Expand Down

0 comments on commit a2eb384

Please sign in to comment.