Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OpenCR device and permissions to group dialout #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucidOne
Copy link

Given modern security issues, it seems like making /dev/ttyACM0 world writable might not be the best choice, perhaps assigning it to group dialout would be better.

In addition to the updated udev rule, this does require that the user is added to the group

$ sudo usermod -a -G dialout $USER

Unfortunately this does not update the current shell so the user needs to log out and back in or run the following command.

exec sg dialout newgrp `id -gn`

Given that many robots have several serial ports, symlinking /dev/ttyACM0 to /dev/opencr0 for matching USB VID/PID seems helpful.

We are happy to help update the documentation if this can be merged.

@OpusK OpusK requested a review from chcbaram February 11, 2019 07:44
@OpusK OpusK self-assigned this Feb 11, 2019
@OpusK OpusK added the accepted label Feb 11, 2019
@OpusK
Copy link
Contributor

OpusK commented Feb 21, 2019

Hi, @LucidOne

With regard to dialout, we want to check compatibility issues.
And, since it uses ST VID / PID now, there is a problem.

In this regard, I will discuss the matter further internally and decide whether to merge PR.

@LucidOne
Copy link
Author

'On Debian and derivatives including Ubuntu this is "dialout"; on Gentoo/Fedora/openSuse it is "uucp".'

Please let me know if you have any questions as I am currently working on some OEM integration tools for OpenCR and would really like to see something like this merged. Particularly symlinking /dev/ttyACM0 to /dev/opencr0 or something like /dev/dmxl0 to make it easier to figure out which serial port on a robot is connected to the dynamixels.

Is Robotis moving to it's own VID/PID?
Is the DFU VID/PID going to stay the same?

@OpusK
Copy link
Contributor

OpusK commented Feb 25, 2019

Is Robotis moving to it's own VID/PID?

It seems to be difficult due to driver support issue under WIN7. (There is also a problem with the boot loader change.)

Is the DFU VID/PID going to stay the same?

DFU remains the same.

@LucidOne
Copy link
Author

@OpusK did you have a chance to look at https://git.sr.ht/~lucidone/dmxl
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants