Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable boost.context build for fiber #1084

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

APokorny
Copy link
Contributor

@APokorny APokorny commented Jan 5, 2025

boost.context fails to autodetect the toolset properly and fails to select the right assembler backend. In the end the backend for boost.fiber is then missing. This change forces the right toolset for boost.context on aarch64.

The solution was copied from:
boostorg/context#139

There are emulators that use boost.fiber/context.

@APokorny APokorny force-pushed the fix/aarch64-boost-build branch 3 times, most recently from 5315b83 to 78db8bb Compare January 9, 2025 23:49
@r3claimer
Copy link
Contributor

I will give this a test after the next release. Will need to do a full build with this change to confirm it doesnt cause any conflicts with current included emulators.

@APokorny APokorny force-pushed the fix/aarch64-boost-build branch 3 times, most recently from ac75f2c to 162b826 Compare January 16, 2025 22:27
boost.context fails to autodetect the toolset properly and fails to
select the right assembler backend. This forces the right toolset for
boost.context on aarch64.

There are emulators that use boost.fiber/context.
@APokorny APokorny force-pushed the fix/aarch64-boost-build branch from 162b826 to 2028012 Compare January 19, 2025 22:07
@r3claimer
Copy link
Contributor

This seems fine, thanks!

@r3claimer r3claimer merged commit 34d52ec into ROCKNIX:dev Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants