adjust to adapt ROCm5.4 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not version specific. The build and tests pass on both ROCm5.4 and 5.3. Forgot to mention it, sorry. |
|
Discussed with @whchung We should NOT have to change any app code like The complain may be caused by HIP SDK, frontend, etc. Let's check the LLVM IR on both versions with "-save-temps" |
|
This change is needed when switching to rocm5.4. |
abojarov
pushed a commit
to abojarov/FBGEMM
that referenced
this pull request
Oct 15, 2024
Update from public repo 2022-08-02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the two intrinsic names to adapt ROCm5.4. Build and tests passed.
20221024_ROCm54_origin-performance_test_log.txt