Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page update #3656

Open
wants to merge 9 commits into
base: hip_runtime_api_how-to
Choose a base branch
from
Open

Landing page update #3656

wants to merge 9 commits into from

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented Oct 31, 2024

No description provided.

@neon60 neon60 force-pushed the landing_page_2 branch 2 times, most recently from fb0ca04 to 208dfd3 Compare November 5, 2024 08:17
MKKnorr
MKKnorr reviewed Nov 5, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
@neon60 neon60 marked this pull request as ready for review November 6, 2024 10:39
@neon60 neon60 requested a review from MKKnorr November 6, 2024 12:47
randyh62
randyh62 approved these changes Nov 6, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but looks good overall.

docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Outdated Show resolved Hide resolved
docs/programming_guide.rst Show resolved Hide resolved
@neon60 neon60 mentioned this pull request Nov 7, 2024
Draft
@neon60 neon60 force-pushed the hip_runtime_api_how-to branch 2 times, most recently from eb41cb1 to 7cb026c Compare November 7, 2024 12:00
@neon60 neon60 changed the title Landing page version 2 Landing page update Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpaoletti lpaoletti lpaoletti approved these changes

@MKKnorr MKKnorr MKKnorr approved these changes

@randyh62 randyh62 randyh62 approved these changes

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@saleelk saleelk Awaiting requested review from saleelk saleelk is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neon60 @randyh62 @MKKnorr @lpaoletti