Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the use_fused_attention filtering #81

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

wangye805
Copy link
Contributor

Use fp8_dpa to filter fused attention, rather than fp8

Fixes #72

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

fix the fused attention filtering

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Use fp8_dpa to filter fused attention, rather than fp8
@wangye805 wangye805 merged commit 2e46618 into dev Oct 17, 2024
@wangye805 wangye805 deleted the fix_fp8_fused_attention_filtering branch October 17, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1xMI300X] GPT-2 XL 1.5B FP8 Training ~30% slower than H100 FP8
2 participants