Code Review

Jump to bottom

Chao Liu edited this page Feb 23, 2022 · 4 revisions

Overall process

Before task start
- Assign a reviewer
- Decide whether to add unit test
PR need to pass CI, before signaled as ready for review
PR review process
- Developer signal PR is ready
- Set up a meeting with reviewer if there is disagreement

For a review comment, only the original reviewer can "resolve" it.
If a PR is merged before all comments are resolved
- A post-merge issue need to be created to track that PR and all unaddressed comments.
Add prefix WIP: in the title if a PR is created but not ready for review and merge. Also the CI system could make use of this.