Add documentation on HIPCC_COMPILE_FLAGS_APPEND and HIPCC_LINK_FLAGS_APPEND #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external HIPCC documentation at https://rocm.docs.amd.com/projects/HIPCC/en/docs-6.2.2/env.html currently only lists two environment variables, HIP_PLATFORM and CUDA_PATH. Other variables such as HIPCC_COMPILE_FLAGS_APPEND and HIPCC_LINK_FLAGS_APPEND have no documentation.
Proposal
Add the below definitions to https://github.com/ROCm/llvm-project/blob/amd-staging/amd/hipcc/docs/env.rst
HIPCC_COMPILE_FLAGS_APPEND: Append extra flags as compilation options to hipcc
HIPCC_LINK_FLAGS_APPEND: Append extra flags as linking options to hipcc