-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorFlow install: Add Python versioning info #170
base: develop
Are you sure you want to change the base?
Conversation
Add clearer example
@yhuiYH Does this work? I'm struggling to convince myself that this is a good user experience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions provided. We may need to keep working on this page to see how it works out....
|
||
.. code-block:: shell | ||
a. To check compatible Python versions, navigate to the desired ROCm release version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions only apply to ROCm 6.1+ because manylinux only has wheels packages for ROCm 6.1+. We should highlight that these are only for 6.1+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think needing users to go through the repository to read the filenames isn't a great experience, could we have another table with the supported versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current sentence:
Using Docker provides portability and access to a prebuilt Docker image that has been rigorously tested within AMD.
Consider:
Using Docker provides portability and access to a prebuilt Docker image rigorously tested by AMD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current sentence:
To quickly validate your TensorFlow environment, let’s run a basic TensorFlow example
New sentence:
Run a basic TensorFlow example to validate your TensorFlow environment quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current:
If successful, you should see the following output indicating the image classifier is now trained to around 98% accuracy on this dataset.
Suggestion:
If successful, you should see the following output indicating the image classifier is now trained to about 98 percent accuracy on this dataset.
6dccd3b
to
b318384
Compare
Spellcheck Reorg
b318384
to
80b5261
Compare
Might need more details on installing older tensorflow-rocm wheels with PyPI |
This PR adds notes about checking which Python versions are supported by a given TensorFlow installation