add a check for kiosk/idu pkgs #16730
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compared multiple idu/kiosk pkgs to normal ones and didnt really see a way to difference them based on metadata
|
If there is no difference in metadata, we can opt to data validity checks after decryption for different keys. Although it seems suspicious. |
Megamouse
reviewed
Feb 20, 2025
rpcs3/Crypto/unpkg.cpp
Outdated
| @@ -478,30 +478,37 @@ bool package_reader::read_metadata() | |||
| return true; | |||
| } | |||
|
|
|||
|
|
|||
rpcs3/Crypto/unpkg.cpp
Outdated
| bool package_reader::decrypt_data() | ||
| { | ||
| if (!m_is_valid) |
There was a problem hiding this comment.
Why are you changing tabs for spaces?
Revert all of these changes please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared multiple idu/kiosk pkgs to normal ones and didnt really see a way to difference them based on metadata.
Usually kiosk/idu pkgs end with -TE in the name, so based on that we can use PKG_AES_KEY_IDU. Not really a great way to do that since if user renames the PKG they wont be able to install it.