Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to npm #153

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Switch to npm #153

merged 4 commits into from
Dec 26, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore

What is the current behavior? (You can also link to an open issue here)
Yarn is used for assets building.

What is the new behavior (if this is a feature change)?
Switched to using npm for asset building. After switching from Yarn to NPM, some packages began triggering peer dependency errors.

To address this temporarily, we are adding the --legacy-peer-deps flag to the npm install step in the GitHub Actions workflow.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian marked this pull request as ready for review December 26, 2024 10:20
@zhyian zhyian requested a review from shvlv December 26, 2024 10:52
@zhyian zhyian merged commit 75672d4 into dev Dec 26, 2024
1 check passed
@zhyian zhyian deleted the chore/switch-to-npm branch December 26, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants