Add digispark kickstarter Attiny85 board and cleanup CI #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add digispark kickstarter Attiny85 board Digispark board is almost same as trinket, but all 6 GPIO are accessible * Update workflows Remove unmaintained actions-rs * Chore: silence warnings
|
This is the same as #367 but I have also cleaned up CI jobs. (Sorry did not notice the other PR) |
|
Hi, thanks a lot for the PR! I've taken the liberty to already apply the CI changes + warning fixes in commits f1010cf ("treewide: Fix warnings") and 1ab563c ("ci: Update workflows"). For the board, I'm not sure how we should proceed, did you notice any notable differences between yours and the other PR? I'll also take another look in the coming days. |
|
@Rahix the other had better comments than my code for the registers but they were more or less identical. |
|
Since the changes are made and merge we can just close this PR now. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds with warnings are errors, all existing warnings were either solved or silenced.