Restructure ADC macros #457
Draft
Commits on Jan 29, 2024
-
mcu: Remove code that will become generated
NOTE: This commit does not yet compile! The motivation for this is not repeating these definitions in both crates. Instead, we will move them into `impl_adc!`, and implement them differently based on which type of timer we're talking about.
-
generic: restructure impl_adc macro
NOTE: This commit does not yet compile! See doc comment on the macro for details and usage.
-
atmega-hal: update adc macro invocations
NOTE: attiny-hal does not yet compile! But now atmega-hal does.
-
-
generic: add comment about the new design
The bit about redesigning could be removed after it's finished, but I'd leave the principles and maybe even add some information for aspiring contributors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.