-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing fstream include #746
Conversation
for more information, see https://pre-commit.ci
FYI the compilation error has nothing to do with the current PR:
|
Thanks. I need to revisit this and setup CI for the pymem branch. I broke this by accident while trying to avoid a deprecation warning from libqglviewer. |
I am hitting a different error in my CI - could I get your eyes into this? |
@miquelmassot I saw you changed CI on the master branch. Did it resolve the issue? |
Noted - I arranged that too - but I might be missing something else: In step:4:176 I am installing Eigen 3.4 but in step:7:558 states that only 3.3.7 is found... I think I am missing something in GHA. |
Seems like https://github.com/miquelmassot/g2o-python/actions/runs/7126447254/job/19404355975#step:7:91 is starting some container where then only an older version of Eigen is available? Reading the docs of this ci tool, seems like we can use https://cibuildwheel.readthedocs.io/en/stable/options/#before-build to specify commands to be run in the container? But I am not really sure here. |
No description provided.