Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem in filesys_tools #748

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Use std::filesystem in filesys_tools #748

merged 3 commits into from
Dec 2, 2023

Conversation

RainerKuemmerle
Copy link
Owner

  • Refactor dl_wrapper to use updated filesys_tools
  • Use unordered_set in dl_wrapper

* Refactor dl_wrapper to use updated filesys_tools
* Use unordered_set in dl_wrapper
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b03c874) 50.88% compared to head (85695ac) 50.87%.

Files Patch % Lines
g2o/stuff/filesys_tools.cpp 90.24% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   50.88%   50.87%   -0.01%     
==========================================
  Files         271      271              
  Lines       10966    10972       +6     
==========================================
+ Hits         5580     5582       +2     
- Misses       5386     5390       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainerKuemmerle RainerKuemmerle merged commit 0a0430f into master Dec 2, 2023
6 checks passed
@RainerKuemmerle RainerKuemmerle deleted the filesystem branch December 2, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant