Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: describes configs used in config.yaml.sample #1767

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

parikshithb
Copy link
Member

Resolves #1765

  • Added comments for different configs except for pvc properties(self explaining)
  • Shows sample clusters, can be uncommented out to make it easy to configure kubeconfig paths.

@parikshithb parikshithb requested a review from nirs January 24, 2025 13:33
@parikshithb parikshithb self-assigned this Jan 24, 2025
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see minor comments.

e2e/config.yaml.sample Outdated Show resolved Hide resolved
e2e/config.yaml.sample Show resolved Hide resolved
e2e/config.yaml.sample Outdated Show resolved Hide resolved
* Added comments for different options except for pvc properties(self explaining)
* Shows sample clusters, can be uncommented out to make it easy to configure kubeconfig paths.

Signed-off-by: Parikshith <[email protected]>
@nirs nirs mentioned this pull request Jan 27, 2025
8 tasks
Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nirs nirs merged commit fccaf70 into RamenDR:main Jan 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: briefly explain about configs used in config.yaml.sample
2 participants