drenv macOS: Update lima to 1.0.4 & install qemu dependency #1781
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
reviewed
Jan 29, 2025
parikshithb
force-pushed
the
lima_version
branch
from
5718e18 to
b0a8a66
Compare
nirs
reviewed
Jan 29, 2025
parikshithb
force-pushed
the
lima_version
branch
from
b0a8a66 to
6201d14
Compare
nirs
reviewed
Jan 30, 2025
test/README.md
Outdated
| @@ -147,6 +148,9 @@ environment. | |||
| lima version 1.0.0 or later is required, latest version is | |||
| recommended. | |||
|
|
|||
| > [!NOTE] | |||
| > Tested with lima version 1.0.4. | |||
There was a problem hiding this comment.
This does not work when indented under a list. Just add the text at the end of the paragraph on line 147.
parikshithb
force-pushed
the
lima_version
branch
from
6201d14 to
d46e3c8
Compare
* Tested with env/regional-dr.yaml cluster creation on mac * Updated lima version in test/README.md * Updated test/README.md to install qemu for macOS due to lima dependency with qemu ([issue #3169](lima-vm/lima#3169)) Signed-off-by: Parikshith <[email protected]>
parikshithb
force-pushed
the
lima_version
branch
from
d46e3c8 to
3095b65
Compare
nirs
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1763