Merge branch 'develop' of github.com:loathingKernel/Rare into develop

RareDevs · Feb 17, 2024 · 68ea7b9 · 68ea7b9
2 parents 5359b73 + db3cf68
commit 68ea7b9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rare/components/tabs/games/game_info/game_settings.py b/rare/components/tabs/games/game_info/game_settings.py
@@ -108,7 +108,10 @@ def __override_exe_edit_callback(self, path: str) -> Tuple[bool, str, int]:
             return True, path, IndicatorReasonsCommon.VALID
         if not os.path.isabs(path):
             path = os.path.join(self.igame.install_path, path)
-        if self.igame.install_path not in path:
+        # lk: Compare paths through python's commonpath because in windows we
+        # cannot compare as strings
+        # antonia disapproves of this
+        if os.path.commonpath([self.igame.install_path, path]) != self.igame.install_path:
             return False, self.igame.install_path, IndicatorReasonsCommon.WRONG_PATH
         if not os.path.exists(path):
             return False, path, IndicatorReasonsCommon.WRONG_PATH