Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rasa readiness probe and configurable path #341

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Add rasa readiness probe and configurable path #341

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d8063
Add rasa readiness probe and configurable path
miraai Jun 13, 2023
fe53a85
Add default /status for liveness probe
miraai Jun 15, 2023
a3ab7c8
Revert changes to liveness probe path for rasa
miraai Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rasa-x/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v2

version: "4.5.18"
version: "4.5.19"

appVersion: "1.2.2"

Expand Down
11 changes: 10 additions & 1 deletion charts/rasa-x/templates/rasa-deployments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,16 @@ spec:
{{- if or $.Values.rasa.livenessProbe.enabled (not (hasKey $.Values.rasa.livenessProbe "enabled")) }}
livenessProbe:
httpGet:
path: "/"
path: {{ $.Values.rasa.livenessProbe.path }}
port: "http"
scheme: {{ default "HTTP" $.Values.rasa.livenessProbe.scheme }}
initialDelaySeconds: {{ $.Values.rasa.livenessProbe.initialProbeDelay }}
failureThreshold: 10
{{- end }}
{{- if or $.Values.rasa.readinessProbe.enabled (not (hasKey $.Values.rasa.readinessProbe "enabled")) }}
readinessProbe:
httpGet:
path: {{ $.Values.rasa.readinessProbe.path }}
port: "http"
scheme: {{ default "HTTP" $.Values.rasa.livenessProbe.scheme }}
initialDelaySeconds: {{ $.Values.rasa.livenessProbe.initialProbeDelay }}
Expand Down
4 changes: 2 additions & 2 deletions charts/rasa-x/templates/rasa-x-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
{{- if or .Values.rasax.livenessProbe.enabled (not (hasKey .Values.rasax.livenessProbe "enabled")) }}
livenessProbe:
httpGet:
path: "/"
path: {{ .Values.rasax.livenessProbe.path }}
port: "http"
scheme: {{ default "HTTP" .Values.rasax.livenessProbe.scheme }}
initialDelaySeconds: {{ .Values.rasax.livenessProbe.initialProbeDelay }}
Expand All @@ -78,7 +78,7 @@ spec:
{{- if or .Values.rasax.readinessProbe.enabled (not (hasKey .Values.rasax.readinessProbe "enabled")) }}
readinessProbe:
httpGet:
path: "/"
path: {{ .Values.rasax.readinessProbe.path }}
port: "http"
scheme: {{ default "HTTP" .Values.rasax.readinessProbe.scheme }}
initialDelaySeconds: {{ .Values.rasax.readinessProbe.initialProbeDelay }}
Expand Down
14 changes: 14 additions & 0 deletions charts/rasa-x/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,17 @@ rasax:
# livenessProbe checks whether Rasa Enterprise needs to be restarted
livenessProbe:
enabled: true
# liveness probe path
path: "/"
# initialProbeDelay for the `livenessProbe`
initialProbeDelay: 10
# scheme to be used by the `livenessProbe`
scheme: "HTTP"
# readinessProbe checks whether rasa Enterprise can receive traffic
readinessProbe:
enabled: true
# readiness probe path
path: "/"
# initialProbeDelay for the `readinessProbe`
initialProbeDelay: 10
# scheme to be used by the `readinessProbe`
Expand Down Expand Up @@ -183,10 +187,20 @@ rasa:
jaegerSidecar: "false"
livenessProbe:
enabled: true
# liveness probe path
path: "/status"
miraai marked this conversation as resolved.
Show resolved Hide resolved
# initialProbeDelay for the `livenessProbe`
initialProbeDelay: 10
# scheme to be used by the `livenessProbe`
scheme: "HTTP"
readinessProbe:
enabled: true
# readiness probe path
path: "/"
miraai marked this conversation as resolved.
Show resolved Hide resolved
# initialProbeDelay for the `readinessProbe`
initialProbeDelay: 10
# scheme to be used by the `readinessProbe`
scheme: "HTTP"
# useLoginDatabase will use the Rasa Enterprise database to log in and create the database
# for the tracker store. If `false` the tracker store database must have been created
# previously.
Expand Down