-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ControllerManager.py #48
Conversation
Added Controller fix
Added comments
More code comments
try: | ||
events = get_gamepad() | ||
for event in events: | ||
if event.ev_type in ['Key', 'Absolute']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd assume the Absolute ev_type is for axis and linear actuators? its a bit weird to use those as PTT, but I guess you kinda have to? To they have a press "amount" property? maybe we should set a threshold for minimum press like 0.6 for press and 0.4 for release to avoid hysteresis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a controller, absolute ev_type probably isn't too useful, but there are probably edge cases for HOTAS users, and maybe controller users that an axis is used for PTT. A threshold would be a great idea :)
Updated to include analog functions, with a threshold.
Gave this a try! |
Very odd. Ok, I have a Hotas due to arrive in a few days, and a PS4 controller. I'll do some more testing and figure out a solution. I expected a HOTAS to not work, but assumed all controllers, including hotas weren't working yet. Shouldn't be a big deal to get it all working (I hope) :) |
We will close this for now. If you want to continue on this, please let us know and we reopen this PR! |
Added Controller fix using inputs lib