-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brazilian Portuguese translation #6199
Conversation
Can you clarify here? Ideally all translations (languages) are based off the same .pot file. We only update that .pot file once per release cycle.
Yes, please do that here
I think no need to do that -- IMO there's no need to have a CI job for each covered language. Currently we include |
Sure. To deliver the result of our work, we generated POT files with However, if you prefer, I can msgmerge it against the POT files currently available in the repository, and the translation messages that might become obsolete (because they don't exist in such POT files) could be reused afterwards once the new POT are generated for the new release. |
Got it. No sense doubling effort to try and undo this, though if we're making a playbook for adding other translations later, let's please note that we should work directly with the existing .pot file on first commit. This time, let's do the following:
|
Co-authored-by: Leonardo Ferreira Fontenelle <[email protected]> Co-authored-by: Ítalo Santos <[email protected]>
d281116
to
a17468d
Compare
PR for updating .pot files opened as #6202. I've generated new files and new strings came up, so PO files updated. |
.po files LGTM! My understanding of Portugese is quite limited, so I can only say:
Once the other administrative requests discussed above are included we can go ahead and merge. Thank you to all translators!! |
Thanks all! |
@MichaelChirico s/Portugese/Portuguese/ in NEWS.md |
Wow this typo even has its own Wiktionary entry 🤓 |
Impressive. Might be a very common typo. |
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
Hello Please take in account that there is at least a line on ( Line 397 in ebc185e
( Line 2775 in ebc185e
That is likely to leave := in i undetected. PD: I has been working in spanish translations if I have some time I will complete and share. Are there a branch on which commit translations or something? |
Hi @Rdatatable/brazil |
Rafael will explain the technical bits better, but in short we used a Web translation platform (Transifex), which was interacting with a custom "datatable-pt_BR" git repository with multiple pt_BR.po files. I had split both the pt_BR and the R-pt_BR files by source code file so that (1) we could have more manageable chunks, (2) the same person would translate messages from the same file in the same day, (3) and translate from the corresponding R and C files in tandem. We had an online spreadsheet marking which file was to be translated by whom and reviewed by whom, and whether each was already done. Moreover, we have an WhatsApp group, and everybody was already briefed when we started translating. |
I would love to see R packages have access to the Weblate. I'll see if I can write something about splitting the PO files, but most of the time working with split files would be easier with every translator having offline translation tools installed on their computers. |
cc @daroczig, it's something we discussed briefly, but don't think we're quite ready to support yet. for now we prioritize getting the base+Recommended packages translations in a good workflow. |
.po files work well. I have successfully used .po on vignettes too. Investigating now about cheat sheets translate possibilities. |
If the issue on R Weblate is being overwhelmed for some reason, I wonder: have you considered using Hosted Weblate? Weblate hosts free/libre software in a "libre plan" that is gratis (zero price) up to 160K strings for the whole project (source language + all translations). C and R po files sums +/- 1200 strings. See https://weblate.org/en/hosting/ |
I don't think it's a server traffic bottleneck, but rather a human maintainer bottleneck :) |
I have some experience as a maintainer of Fedora Weblate (adding projects, improving project's custom placeholders, handling push/merge/etc. alerts). Let me know if you need a hand on this matter. |
yeah, there's no formal process to add non R Core/Recommended pkgs to the current weblate server, but I don't see any good reason why not change that right now :) if there's interest, I'm happy to set up a new project and import the PO file(s) as components -- or feel free to do so yourself. Or let's jump on a call at your convenience to discuss? |
Dear data.table contributors: I has recently been working in spanish translations for R and data.table. Currently i've finished to check my translations and also added the most recent commited strings (some message related to inplace droplevels() not translated because not yet in template). These are in https://github.com/rikivillalba/data.table/tree/Spanish-translations Some comments:
I hope these translations be useful. If it is so how to proceed? Thanks! |
@rffontenelle I think this is meant to say "português" rather than "inglês". What do you think? |
Hi @rikivillalba thanks for volunteering. |
@MichaelChirico can you confirm that translators should change the first occurrence of "English" to the target language name in the sentence below? Lines 27 to 28 in b8d5f83
|
Relevant thread: #3935
|
yes please!
Please just use (similarly maybe
Good point! I was operating under the assumption that the package po/ directory is not bundled up in the tar for CRAN, but I checked and indeed it is! download.file("https://cran.r-project.org/src/contrib/data.table_1.15.4.tar.gz", tmp<-tempfile())
writeLines(grep("data.table/po/.", untar(tmp, list=TRUE), value=TRUE))
# data.table/po/R-zh_CN.po
# data.table/po/data.table.pot
# data.table/po/zh_CN.po
# data.table/po/R-data.table.pot Filed #6331 to remove these -- all the installed package needs is the compressed .mo files in inst/po, which are O(100K) per language. I don't think we need to consider excluding the .mo files from the CRAN installation, for now. |
You're welcome @tdhock. I was not aware of the past october call. |
please open a PR when you're ready! and immense thanks! |
Hi, Since a lot of translation stuff is going on right now, i was wondering if their is any hindi translation team ?, i will like to help out if there is any, if there is none i might start it on my own as well, WDYT ? @MichaelChirico @tdhock |
I can't say for sure. Even though they are close languages and the reader from one language might be able to understand the other, the differences make it a little bit weird or unnatural. My assumption is that the user of data.table and R is not new to English (so many books or man page in English!), hence seeing pt_BR when expected pt_PT (or original English) might a little bit annoying. Can this question be made public somewhere to try to reach target audience from Portugal and other countries Portuguese-speaking countries? |
@Nj221102 you should ask @SaranjeetKaur about joining the Hindi translation team. |
Just did that. After making |
This is the result of the task force by me, Leonardo Fontenelle and Italo Santos to translate data.table.
Besides providing these PO files, I tracked other possible changes I could include in this pull request, however I didn't add because I wanted to check with you first. These are:
Please let me know if I should apply those changes as well.