refactor(editor): refactor Editor_ConvertSpawns function #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `Editor_ConvertSpawns` function to improve code readability and maintainability. Renamed the function from `static bool: Editor_ConvertSpawns()` to `static ConvertOldSpawnsFile(const file[])`. Modified the function to return the count of successfully converted spawns instead of a boolean value. Introduced conditional checks and log messages to handle edge cases, such as when no valid spawn files are found or when an invalid argument count is encountered. Updated the commit message to reflect these changes.
SergeyShorokhov
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #79
Refactored the
Editor_ConvertSpawnsfunction to improve code readability and maintainability. Modified the function to return the count of successfully converted spawns instead of a boolean value. Introduced conditional checks and log messages to handle edge cases, such as when no valid spawn files are found or when an invalid argument count is encountered. Updated the commit message to reflect these changes.