Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scrolling To Text Boxes #126

Merged
merged 3 commits into from
May 27, 2024

Conversation

TheBrokenRail
Copy link
Contributor

Screencast.from.2024-05-14.16-20-49.webm

Copy link
Contributor

@BrentDaMage BrentDaMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good.

source/client/gui/components/TextInputBox.cpp Outdated Show resolved Hide resolved
source/client/gui/components/TextInputBox.cpp Outdated Show resolved Hide resolved
source/client/gui/components/TextInputBox.cpp Outdated Show resolved Hide resolved
source/client/gui/components/TextInputBox.cpp Show resolved Hide resolved

drawString(m_pFont, "_", m_xPos + xPos, m_yPos + textYPos + 2, 0xFFFFFF);
std::string str;
Copy link
Member

@iProgramMC iProgramMC May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, std::string(1, CURSOR_CHAR). Just a minor nitpick though.

@iProgramMC iProgramMC merged commit 78ae969 into ReMinecraftPE:master May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants