Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve documentation #1411
base: compose-dev
Are you sure you want to change the base?
docs: Improve documentation #1411
Changes from 90 commits
e7b9486
676eb1e
67603f6
85c6e72
26b9652
830a666
949b1da
e0dfbaf
9b9525e
f732df1
a503f48
a280fc2
cd5787a
2f0cdff
b8378fb
259f763
d58fd96
8a3d163
7bf1a5a
3c083ed
2f782b4
98747f4
1f5331d
8acdc17
0d2d879
a70ad3d
1877408
7b49af2
cf9a14c
d06fb08
f14b697
a3c48d1
07ee005
891fb57
10815c8
a8682d6
af49457
94eb893
dcf51c1
2f31fc7
0419b2f
bc09af9
944b57c
2a3395c
d32a213
35996b6
1521d21
62bb0d3
3c56db4
94de170
ace6701
adf5f9f
a290369
db4ce6b
3bbad15
05bf940
8442bf2
911201a
5125084
50c46dc
d987845
177b716
4364f2e
04a2a78
b0624a3
91e06cb
03c9168
6dfb2a2
44fc455
2616576
bec0d82
5b790a8
6598db5
617481f
d1ef14a
802330c
1c6a9db
a53a0bd
8f9ea54
db304a7
d3748cf
91f6672
5993dc3
046179d
351e00c
d47819c
15cfeb6
0eee869
b9401b5
c2a942b
8731e72
a5d09b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each page has an icon so if linking to one the icon should be present in it. Linking back is not necessary here though, as we don't do it consistently in other pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording in the main branch is better than here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be step 3, if at all, not a separate title. However this section can be removed entirely, verifying can be added consistently later in all repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem like enough information for a user to successfully verify an APK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the official Android docs to verify the APK should be referenced and/or the official documented method should be mentioned here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording in main branch is better than here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May have to be rewritten for Compose version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 1 should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to select from storage unless you have downloader plugins installed, which is not mentioned here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to render correctly

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested note blocks don't render unfortunately. See how the main branch solves this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, this should not be a separate section, follow how the main branch does it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this section is necessary. This is explained inside the app and changing selection is not recommended.