-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add banner for when the API is down #254
base: dev
Are you sure you want to change the base?
Conversation
Caution should use a different icon & all the colors are too saturated, use the same saturation/contrast as the other colors. The info banner should use the blue highlight color |
Such as? I've searched for "caution" on svgrepo.com
They're just placeholders, I didn't really follow the theme (for now)
The text selection color wasn't altered, or are you referring to something else? |
If the PR isn't ready, mark as a draft |
above commit ^^^ tested to work with static build |
Warning should be orange/yellow tinted |
I couldn't find anything that follows the m3 color rules |
Co-authored-by: oSumAtrIX <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Resolve the navbar not sticking to the top when scrolling
- Confirm the API outage banner is only displayed when appropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The margin-top
changes across pages doesn't consider cases where there is no banner being displayed, perhaps a minor refactor where we wouldn't need magic numbers would be good
@Ushie where exactly? |
The issue is a bit difficult to solve. The banner is sticky so we have to simulate a hidden non sticky banner so the content shifts down. I guess what we can do is add the margin to that simulated banner, so when the banner is hidden, the margin is gone too |
What's this?
This PR adds the
<Banner />
component and some functionality. Originated from issue #191Screenshots (as of commit 8fa880b)
Level:
caution
Level:
warning
Level:
info