Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate events with state for feedbacks #12

Merged
merged 4 commits into from
Jul 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Example/UnifiedStoreUIKitExample/UnifiedStore.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,19 @@ enum UnifiedStore {
)
)

private static let feedbacks: Loop<State, Event>.Feedback = Loop<State, Event>.Feedback.combine(
Loop<State, Event>.Feedback.pullback(
feedback: Movies.feedback,
private static let feedbacks: Loop<State, Event>.Feedback = Movies.feedback
.pullback(
value: \.movies,
event: Event.movies
embedEvent: Event.movies,
extractEvent: { (event) -> Movies.Event? in
switch event {
case let .movies(moviesEvent):
return moviesEvent
default:
return nil
}
}
)
)
}

extension UnifiedStore {
Expand Down
17 changes: 12 additions & 5 deletions Loop/Floodgate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@ final class Floodgate<State, Event>: FeedbackEventConsumer<Event> {
}
}

let (stateDidChange, changeObserver) = Signal<State, Never>.pipe()
let (stateDidChange, changeObserver) = Signal<(State, Event?), Never>.pipe()

/// Replay the current value, and then publish the subsequent changes.
var producer: SignalProducer<State, Never> {
return feedbackProducer.map(\.0)
}

private var feedbackProducer: SignalProducer<(State, Event?), Never> {
SignalProducer { observer, lifetime in
self.withValue { initial, hasStarted -> Void in
observer.send(value: initial)
observer.send(value: (initial, nil))
lifetime += self.stateDidChange.observe(observer)
}
}
Expand All @@ -40,10 +44,13 @@ final class Floodgate<State, Event>: FeedbackEventConsumer<Event> {
dispose()
}

func bootstrap(with feedbacks: [FeedbackLoop<State, Event>.Feedback]) {
func bootstrap(with feedbacks: [Loop<State, Event>.Feedback]) {
for feedback in feedbacks {
// Pass `producer` which has replay-1 semantic.
feedbackDisposables += feedback.events(producer, self)
feedbackDisposables += feedback.events(
feedbackProducer,
self
)
}

reducerLock.perform {
Expand Down Expand Up @@ -122,6 +129,6 @@ final class Floodgate<State, Event>: FeedbackEventConsumer<Event> {

private func consume(_ event: Event) {
reducer(&state, event)
changeObserver.send(value: state)
changeObserver.send(value: (state, event))
}
}
Loading