-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform a complete environment refresh for Studio install, build, deploy #255
Conversation
Changed Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 21 21
Lines 1810 1810
Branches 327 327
=======================================
Hits 1594 1594
Misses 179 179
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a question about the MANIFEST.in file and whether it's necessary anymore. Also, while looking at the docs in the demo API that is spun up I noticed that the help message for the /langs
endpoint is incorrect. It gives this as an example:
[
{"code": "alq", names: { "alq": "Anishinaabemowin", "_": "Algonquin" }},
{"code": "atj", names: { "atj": "Nehiromowin", "_": "Atikamekw" }},
{"code": "fra", names: { "fra": "Français", "_": "French" }},
...
]
but Français, Anishinaabemowin, and Nehiromowin don't actually show up, and I can't see any other examples of this. Also - by this logic, why is _
not eng
?
I fixed the langs help message.
|
4f8811e
to
6d5e347
Compare
a7cecdb
to
103c232
Compare
hatch env remove prod rm requirements.txt hatch env create prod
103c232
to
15c8745
Compare
PR Goal?
Big jump in all the environment management for ReadAlongs/Studio:
setup.py
andrequirements*.txt
bypyproject.toml
We still need a
requirements.txt
file for Heroku, but it's now effectively a lock file generated usinghatch
.Feedback sought?
General review
Priority?
medium
Tests added?
yes, CI now has a dedicated reproducing the full Heroku way to build
How to test?
This version is currently deployed in preview mode on the heroku-24 stack at:
https://readalong-studio-heroku-24-488739ed89f8.herokuapp.com/api/v1/docs
(blocked as "Suspicious" on NRC networks, works elsewhere)
Confidence?
pretty high
Version change?
no