refactor align helper functions out of align.py #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
align.py is a monster file doing too much stuff. This PR takes the alignment I/O out to align_utils.py.
The work was inspired by #170, which is non essential, but I decided to do it because it makes the code somewhat cleaner, and the Heroku image leaner.
Not done: I'm not sure how to declare, when updating(added documentation to do it on update).requirements.txt
frompyproject.toml
, to exclude soundswallower...Fixes?
Fixes #170
Priority?
low
Tests added?
This was almost all already covered by existing tests. I just had to do minor tweaks on the heroku workflow to streamline it.
Confidence?
high
Version change?
no