Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce time limit on assemble as a whole, not just g2p #262

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 25, 2025

PR Goal?

I can still generate 503 with large text via the API, so this PR enforces the time limit on the whole of assemble, not just on g2p processing.

Feedback sought?

rubber stamping

Priority?

before ICLDC

Tests added?

yes

How to test?

requires messing with the API directly, giving it a very large payload.

Confidence?

high

Version change?

no

Copy link

semanticdiff-com bot commented Feb 25, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  readalongs/text/convert_xml.py  61% smaller
  readalongs/web_api.py  20% smaller
  test/test_web_api.py  19% smaller

@joanise joanise requested a review from roedoejet February 25, 2025 17:40
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (7e2ccc9) to head (34c76da).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   88.38%   88.41%   +0.03%     
==========================================
  Files          22       22              
  Lines        1859     1864       +5     
  Branches      336      338       +2     
==========================================
+ Hits         1643     1648       +5     
  Misses        179      179              
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise requested a review from deltork February 25, 2025 22:42
@joanise joanise merged commit 34c76da into main Feb 28, 2025
8 checks passed
@joanise joanise deleted the dev.ej/timelimit-assemble branch February 28, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant