feat: summarize g2p errors in assemble and on the CLI #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
In assemble, just list the words that could not be g2p'd, so the error message shown to the user in Studio-Web is legible.
In the CLI, add a summary list of the words that could not be g2p's in the error message.
Fixes?
Unreadably verbose errors shown to users in Studio-Web when some tokens cannot be g2p'd.
Feedback sought?
sanity checking
Priority?
before ICLDC ideally
Tests added?
yes
How to test?
In Studio:
In Studio-Web:
Navigate to http://localhost:4200/ and put non-g2p-able text like

54:23 1223:563 54:23
and see the nice and sweet error message like this when you click on next step:Confidence?
high
Version change?
Before ICLDC, I might choose to bump Studio's version to 1.2.2 with the several little patches we've done recently.