Dark Mode for the status site #251
Conversation
…website-status into feat/dark-mode-sass
…website-status into feat/dark-mode-sass
…website-status into feat/dark-mode-sass
There was a problem hiding this comment.
@brandong512 Please check why the tests/checks are failing by clicking on the details
src/pages/index.tsx
Outdated
| @@ -114,6 +124,8 @@ const Index: FC = () => { | |||
| }, [isLoading, response]); | |||
|
|
|||
| useEffect(() => { | |||
| console.log("in use effect: ", checkThemeHistory(document.cookie, query)) | |||
There was a problem hiding this comment.
Please avoid adding console statements to production
There was a problem hiding this comment.
No problem I'll go ahead and remove that
| const themeSetter = () => { | ||
| document.cookie = setCookie(!mainDarkMode); | ||
| setMainDarkMode(!mainDarkMode); | ||
| } |
There was a problem hiding this comment.
We can move this function to helper functions, as the same function is used in multiple pages. What do you think?
There was a problem hiding this comment.
I was actually struggling to do something like this. The issue here is that document.cookie is a global argument that relies on the component itself loading. If I try to put this argument in a helper function and it's called immediately before the DOM loads, then an error will show saying document doesn't exist.
Any suggestions?
|
@brandong512 Please add the dark mode feature changes for Availability panel also which is currently behind a feature flag( |
|
Sounds good I'll go ahead and start working on these changes. Sorry for the delay! |
…tatus into feat/dark-mode-sass
…website-status into feat/dark-mode-sass
|
@akshay1502
@rohan09-raj
@whyDontI
Not sure why the long chain of commits, but I'm open to learning more about it/correcting it