Skip to content

Commit

Permalink
found an error while removing popup menus (psib.children.forEach is n…
Browse files Browse the repository at this point in the history
…ot a function) - could be related to issue 59 - can't drop email to subfolder
  • Loading branch information
RealRaven2000 committed Sep 17, 2020
1 parent faa23cb commit 35a5503
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
11 changes: 9 additions & 2 deletions chrome/content/quickfolders.js
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,11 @@ var QuickFolders = {
if (psib.label) util.logDebugOptional("dnd", "check next sibling + " + psib.nodeName + " '" + psib.label +"' ...");
if (psib.nodeName === 'menu' && popupStart !== psib) {
if (psib.label) util.logDebugOptional("dnd", "Hiding previous popup menu.");
psib.children.forEach(x => { if (x.tagName=='menupopup') x.hidePopup(); });
// HTMLCollection
for (let x of psib.children) {
if (x.tagName=='menupopup') x.hidePopup();
}
// psib.children.forEach(x => { if (x.tagName=='menupopup') x.hidePopup(); });
}
psib = psib.nextSibling;
}
Expand All @@ -1168,7 +1172,10 @@ var QuickFolders = {
if (psib.label) util.logDebugOptional("dnd", "check previous sibling + " + psib.nodeName + " '" + psib.label +"' ...");
if (psib.nodeName === 'menu' && popupStart !== psib) {
if (psib.label) util.logDebugOptional("dnd", "Hiding previous popup menu.");
psib.children.forEach(x => { if (x.tagName=='menupopup') x.hidePopup(); });
for (let x of psib.children) {
if (x.tagName=='menupopup') x.hidePopup();
}
// psib.children.forEach(x => { if (x.tagName=='menupopup') x.hidePopup(); });
}
psib = psib.previousSibling;
}
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"manifest_version" : 2,
"name" : "QuickFolders",
"description" : "Bookmark your favorite mail folders in Thunderbird.",
"version" : "5.0pre80",
"version" : "5.0pre82",
"developer" : {
"name" : "Axel Grude",
"url" : "http://quickfolders.org/index.html"
Expand Down
2 changes: 1 addition & 1 deletion revision.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
79
82

0 comments on commit 35a5503

Please sign in to comment.