-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to switch fiat currencies #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
Issue regarding conversions (normally the with the current euro / dollar rate the netValue must be 1.07 lower in euro than in dollar be the current return value is 1.03 upper. So it's signify a problem in conversion.
Please refer to my comments to understand the error and fix it
Note:
Regarding the fact that page need to be refresh to update the price don't worry. We are thankful for your participation and will help you getting something smooth
Thank you for the review ! I will have a deeper look to it and will be very happy to increase my skills on React by your reviews and advices :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR with your previous review and added some comment to my code on parts I'm not sure about. Could help me to clarify the interrogations I have ?
Thank you :)
Let me check |
Update the following cards to take into account currency changed
|
Fixes #12 Currently, the dashboard only display prices in `$` fiat currency. This PR adds a new option allowing to switch from `$` to `€` using accurate rate provided by Gnosis API.
847dd99
to
89f40ff
Compare
last 4 commits have are the result of a peer coding with @anthony-robin. The currency switch is now dynamic and use store |
Updated the PR to handle more components currency switch |
Pushed an update to the |
Addressed last Nandy's suggestion by passing rate from the parent to each asset components to avoid too many API calls. I still have some hydratation issues showing up on the table view, I'm not sure what the issue is... |
My most recent commits have:
|
Fixes #12
Currently, the dashboard only display prices in
$
fiat currency. This PR adds a new option allowing to switch from$
to€
using accurate rate provided by Gnosis API.I made most of changes to handle multiple currencies by my React knowledges are not strong enough for me to make it reactive. For now a page refresh is still necessary to update the price.
Feel free to commit to this MR, pushing appropriate changes, and refactor my code if it does not follow the React best practices or rules <3
Co-Authored-By @NandyBa