Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat: add selector for the amount of thumbnails per page #50

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

NandyBa
Copy link
Member

@NandyBa NandyBa commented Jun 14, 2024

This PR introduces a feature requested by @jojodunet that allows users to choose the number of thumbnails displayed per page in the grid view. This enhancement is accessible at the end of the page and offers multiple choice options to suit different user preferences. Additionally, there is an option to display all thumbnails on a single page.

@NandyBa NandyBa linked an issue Jun 14, 2024 that may be closed by this pull request
@NandyBa NandyBa requested a review from jycssu-com June 14, 2024 01:33
Copy link
Collaborator

@jycssu-com jycssu-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use 0 as the value to display all cards rather than the total length. Indeed, if you choose "All" with some filters/search, they will not all be visible when the filters/search are removed.

Ex: Search for "bird" -> choose "All" -> Clear search ==> Only one card visible

@jojodunet
Copy link
Contributor

jojodunet commented Jul 18, 2024

Hello @jycssu-com ,

I tried to contact @NandyBa directly but I haven’t received a response.

Is it possible for you to make the modification on your side and merge the code, please?

Thank you in advance for your help.

Best regards.

@NandyBa NandyBa force-pushed the add-selector-for-the-amount-of-thumbnails-per-page branch from bbd5bfc to 9e906b7 Compare July 31, 2024 07:37
@NandyBa NandyBa force-pushed the add-selector-for-the-amount-of-thumbnails-per-page branch from 9e906b7 to d778d54 Compare July 31, 2024 07:39
@NandyBa
Copy link
Member Author

NandyBa commented Jul 31, 2024

You should use 0 as the value to display all cards rather than the total length. Indeed, if you choose "All" with some filters/search, they will not all be visible when the filters/search are removed.

Ex: Search for "bird" -> choose "All" -> Clear search ==> Only one card visible

Case handle in this last commit
I use Infinity instead of 0, it's make more sense

@NandyBa
Copy link
Member Author

NandyBa commented Jul 31, 2024

I have also rebased the develop branch

@NandyBa NandyBa requested a review from jycssu-com July 31, 2024 07:48
@NandyBa
Copy link
Member Author

NandyBa commented Jul 31, 2024

Hello @jycssu-com ,

I tried to contact @NandyBa directly but I haven’t received a response.

Is it possible for you to make the modification on your side and merge the code, please?

Thank you in advance for your help.

Best regards.

Sorry, I responded but quite after, discord is not my main social, Telegram is more

@NandyBa NandyBa dismissed jycssu-com’s stale review August 17, 2024 19:00

Alexis can review the PR before

@NandyBa NandyBa force-pushed the add-selector-for-the-amount-of-thumbnails-per-page branch from f5401d2 to 57aa448 Compare August 17, 2024 19:15
@AlexRLT AlexRLT self-requested a review August 17, 2024 19:22
@AlexRLT AlexRLT merged commit 08ba640 into develop Aug 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Number of Thumbnails per Page
4 participants