Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimate fully rented rent #60

Merged
merged 23 commits into from
Aug 18, 2024
Merged

Estimate fully rented rent #60

merged 23 commits into from
Aug 18, 2024

Conversation

NandyBa
Copy link
Member

@NandyBa NandyBa commented Aug 8, 2024 •
edited
Loading

PR Status: Ready for Review

Summary of Changes:

  • Implemented fully rented APR estimation based on the maximum property APR. Displayed on the property card.
  • Introduced a general fully rented APR estimation on RentsCard
  • Synchronized the fully rented indicator with the RentCalculation logic (Real-time / Global).
  • Added a disclaimer to indicate that this feature is currently in beta and must be consider as informational only
  • Included the fully rented APR in each property details screen.

Feature requested by:

@jojodunet on #51

@NandyBa NandyBa linked an issue Aug 8, 2024 that may be closed by this pull request
[Suggestion] Max Yield Indicator #51
Closed
@NandyBa NandyBa requested a review from jycssu-com August 15, 2024 22:45
@AlexRLT AlexRLT self-requested a review August 18, 2024 04:06
@AlexRLT AlexRLT merged commit a78c828 into develop Aug 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexRLT AlexRLT AlexRLT approved these changes

@jycssu-com jycssu-com Awaiting requested review from jycssu-com

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggestion] Max Yield Indicator
2 participants
@NandyBa @AlexRLT