Feature: new assets REG, REG Vote Power, RWA realtime price, Settings updates #91

BenoistP · 2024-11-05T18:14:16Z

Prices for RWA & REG are fetched from Honeyswap (UniV2) pools (average of 2 pools: asset/USDC and asset/wXDAI)
Filter 'other' assets (i.e. others than RealTokens) in views using a switch (Others assets) in settings
domain static.debank.com is used for diplaying REG image
next.config.js
small fix when address has no corresponding user ('User not found' error)
src/components/assetsView/AssetsViewSearch.tsx
Misc updates in Setting menu
- icons in switches
Labels optional icon
Interfaces RWARealtoken, REGRealtoken, REGVotingPowertoken are the same thing as OtherRealtoken (previously named RWARealtoken)
ABIs
- ERC20: Full abi
- UniswapV2FactoryABI
Consts: tokens & factory addresses, decimals, default prices
consts/otherTokens.ts

'other' assets = tokens others than RealTokens = RWA, REG, ... - Display switch for hiding 'other' assets in table rows - 'other' assets figures added to Summary section

not fully tested

jycssu-com · 2024-11-07T09:58:51Z

Everythings seems good to me, i just added a check for fetching other assets balances only if the addressList is not empty for avoid a double request on app initialization

Despite this, there are still a large number of RPC requests going out, but it seems to be related to the RPC initialization mechanism to look for a working one, so out of the scope of this PR (maybe we need another PR to improve this part)

@NandyBa I'll let you review it on your side too, and approve if everything is good for you (I can't since I committed)

…l invest

…oid futurs errors

- Check Providers ability to handle requests - Additionnal providers https://rpc.ankr.com/eth and https://eth-pokt.nodies.app currently fail to handle concurrent requests

BenoistP · 2024-12-04T16:21:56Z

I've added a test for checking providers ability to handle concurrent requests:
(On ETH https://rpc.ankr.com/eth and https://eth-pokt.nodies.app currently fail to resolve balances when "too much" requests are sent)
Smol fix: getAddressesLockedBalances was fetching vault balances on Eth
Added 2 additionnal providers for each chain
Assets prices are now converted from USDC/XDAI to USD before being displayed in user choosen currency
Additionnal parameters on batchCallOneContractOneFunctionMultipleParams for fine tuning calls (batch sizes, attempts)

- Both SummaryCard and AssetsView use the same hooks for getting their data, leading to duplicate web3 requests Moving hooks in parent components prevents this form happening.

BenoistP · 2024-12-06T18:16:17Z

Hooks calls are duplicated in 2 components (SummaryCard and AssetsView) so the same requests are made when fetching data.
Moving it to index solves it, let me know if it's considered "dirty" i'll revert the last commit.

src/components/assetsView/filters/AssetsViewSort.tsx

src/utils/blockchain/regVault.ts

NandyBa

When loading the dashboard locally I got 18 properties instead of 20. And when I try a search of RWA on the search bar I don't have it.

filter has to be in assetsView/AssetsView.tsx

BenoistP · 2024-12-13T18:25:00Z

When loading the dashboard locally I got 18 properties instead of 20. And when I try a search of RWA on the search bar I don't have it.

Fixed ser, thanks for your findings and pointing out

NandyBa

Still present

Normal comportment:

Config: no option enabled

OtherAssets filtering was improperly implemented into the map loops by skipping non "others assets" value, causing holes in display (missing cards). Filtering is now done in AssetsView where it should have been in the first place

BenoistP · 2024-12-13T23:16:50Z

Should be fixed now, translated paging labels at the same time

src/i18next/locales/en/common.json

NandyBa · 2024-12-14T16:11:32Z

src/repositories/RpcProvider.ts

+      rpcThresholdValue = await testRpcThresholds(
+        provider,
+        REG_ContractAddress,
+        5,
+        5,
+        5,
+        150,
+      )
+      if (rpcThresholdValue < 1) {
+        // Throw error if the threshold is 0
+        // Means the provider is not able to handle required concurrent requests number
+        // skip it and try next one
+        throw new Error('rpcThresholdValue returned 0')
+      }
+      // If any error has occurred before, log the successful connection
+      if (failedRpcErrorCount > 0) {
+        console.info(
+          `Successfully connected to ${url} after ${failedRpcErrorCount} failed attempts`,
+        )
+      }
+      return provider
    } catch (error) {
-      console.error(`Failed to connect to ${url}, trying next one...`)
+      failedRpcErrorCount++
+      if (!rpcConnectOk) {
+        // Connection error
+        console.error(`Failed to connect to ${url}, trying next one...`, error)
+      } else if (rpcThresholdValue < 1) {
+        // Threshold error
+        console.error(
+          `Successfull connection to ${url} BUT failed to test rpcThresholdValue, trying next one...`,
+          error,
+        )
+      } else {
+        // General error
+        console.error(`Failed to connect to ${url}, trying next one...`, error)
+      }
    }
  }
+  throw new Error(`All RPC URLs (${urls?.length}) failed`)
+}


This part slow down the page loading

I recommend to run it appart from the front

I'll see if i can improve things but if these tests aren't run then there's no garantee next batchs requests will succeed and nothing will be loaded if the rpc can't support multiple requests at the same time (like https://rpc.ankr.com/eth seems like not supporting it)

Can we populate the code with test results and run tests only for new RPCs, instead of running all tests every time? I don’t want to block the PR, but I think merging it like this is manageable in the develop branch. However, it might create blockers later when escalating to preprod and prod.

Checks for testing rpc ability to handle batch requests only run once for each rpc, one after the other like it is already the case.
Currently rpc connection checks take around 700ms, additionnal batch check requires 100-150 ms more.
If the first rpcs fails to respond and to handle batch request, the second is tested and so on.

Sigri44 · 2024-12-15T21:48:17Z

@NandyBa Where are we now? Are there any requests that don't concern the original PR, if I understand correctly?

NandyBa · 2024-12-15T21:55:17Z

@NandyBa Where are we now? Are there any requests that don't concern the original PR, if I understand correctly?

???
Currently all is good expect: #91 (comment)

NandyBa

Approved. We will revisit the RPC test if we find it annoying

* Change NS for RealToken (#89) * chore: install required sharp dependency for production * chore(deps): bump body-parser from 1.20.2 to 1.20.3 (#87) Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.2...1.20.3) --- updated-dependencies: - dependency-name: body-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add new assets REG, REG Vote Power (#91) * first version : Assets as rows * 'other' assets display switch; 'other' assets shown in Summary 'other' assets = tokens others than RealTokens = RWA, REG, ... - Display switch for hiding 'other' assets in table rows - 'other' assets figures added to Summary section * contracts utils * use contract utils for fetching balances * Eth provider removed: REG Voting Power is not deployed on Eth * batchCallOneFunction not fully tested * error args * comments * wrong 'inheritance' * smol fix: properly throw 'User not found' error * style/comments * settings labels and icons * unitIcon: optional + alignment with other units * Filter 'other' assets in Grid view * Settings: switch icons, section names * fix: lint warning * fix: lint warning * fix: build error ? * fix: build error #2 ? * fix: build error #3 ? * fix: build error #4 ? * fix: build error #5 ? * Fix: existing filter error when filtering on "Owned on" * fix: avoid fetching others assets balances if user wallet was not set * feat: add other token price on cards and fix decimals rounds for total invest * fix: improve subsudy filter for exclude other realtokens * fix: fix last changes filter and use correct typing in filters for avoid futurs errors * feat: set initial launch date for RWA token * feat: initialize rpc provider only once * feat: include reg tokens locked inside the incentive vault * fix: fix eslint warnings and add missing translations * Update .gitignore exclude pnpm lockfile * Create .nvmrc add .nvmrc for switching between node versions * Update contract.ts optional parameters for customizing batch calls: batch max and min size, number of attempts before giving up * Regvotingpower: icon orange, size grows depending on amount * unused import * Usdc currency/rate * Voting power size & fill color depending on power amount * Voting power size & fill color depending on power amount * Fixes: token prices in USD, avoid fetching REG vault balances on Eth - Tokens values fix: Updated assets prices by using currenciesRates and user currency rate (previously considering usdc = usd and xdai = usd as well), now assets prices are converted from their respective currencies (e.g. usdc, xdai) to usd, then total value is priced in user choosen currency. - Smol fix: getAddressesLockedBalances was fetching vault balances on Eth, throwing errors as there is not such vault on Eth. Added parameters for fetching any number of vault by provider(s). * comment * Check Providers ability to handle requests - Check Providers ability to handle requests - Additionnal providers https://rpc.ankr.com/eth and https://eth-pokt.nodies.app currently fail to handle concurrent requests * Assets hooks moved in index for avoiding duplicate requests - Both SummaryCard and AssetsView use the same hooks for getting their data, leading to duplicate web3 requests Moving hooks in parent components prevents this form happening. * prettier * Avoid divide by zero in case asset.totalUnits is unknown/zero * "Clean" scripts * Assets filtering moved to the right place filter has to be in assetsView/AssetsView.tsx * Paging translation labels: placeholder, All * simplify pageSize handling * Assets filtering fix (causing pagination issues) OtherAssets filtering was improperly implemented into the map loops by skipping non "others assets" value, causing holes in display (missing cards). Filtering is now done in AssetsView where it should have been in the first place * Revert changes: realtime/global labels for rents calculation switch --------- Co-authored-by: Jycssu <[email protected]> * fix: API URLs issue #97 (#98) * addresses issue #97 Moves api urls to (.)ENV set utls to new api.realtoken.community domain (previously api.realt.community) * Update .env.sample missing update of sample .env * Update .env.sample * NEXT_PUBLIC_ prefix removed for REALTOKENAPI ENV vars * feat: update yarn lock (#99) * feat: add new API urls to deployment workflow (#100) * feat: pass new env variables to docker env (#101) * fix: unchecked asset filters (#95) * merge master in develop (#103) * Revert "Master" * merge preprod <> master (#67) * add dropdown * simplify selector and add all token option * feat: change allPage value to Infinity * feat: estimate the fully rented rent * feat: add fully rented estimation to asset cards * refactor: move hook calls to top of the page * fix: propInfo definition * fix: last rent condition * feat: add estimation for property with not fully rented history * feat: get fully rented APR * apply max APR method * rename variable and functions * feat: add RWA token * feat: re-enable property onClick * feat: add rwa valuation on the rwa card * fix: missing property * feat: add rwa to summary card * define useRWA * take into account user currency * feat: add RWA value to net value calculation * remove comment * refactor: clean imports * feat: include RWA on Ethereum * fix: en communs * feat: update filter to support RWA token * fix: prettier * fix: other prettier errors * let prettier add strange semi-column * fix: imports * use hook * add fallback * switch for a useMemo * feat: add real time fully rented APR * feat: add gloabl metric fully rented APR * feat: add disclaimer * feat: add disclaimer * feat: update disclaimer message * fix: disclaimer message * improve message * feat: create yam statics stics page * feat: add yam statistics for all RealT Tokens on Gnosis (who have Gnosis chain contract prop) * feat: mask tokens with no volume * fix: add token name * feat: add pagination * feat: improve style * feat: change token per page to 100 * feat: add fully rented APR to asset grid * refactor: remove logs * feat: add fully rented APR to property details * fix: reset current page when tokens changed * fix: reset current page when user change page size * feat: add translation for YAM statistics hearder label * fix: yamStatistics: use selected currency for token price * feat: yamStatistics: add owned | all filter * feat: yamStatistics: add subsidized, fullySubsidized and notSubsidized filters * add additional fallbacks RPC URLs * fix: RPC initialization on currencies file --------- Co-authored-by: Nandy Bâ <[email protected]> * merge preprod <> master (#77) * add dropdown * simplify selector and add all token option * feat: change allPage value to Infinity * feat: estimate the fully rented rent * feat: add fully rented estimation to asset cards * refactor: move hook calls to top of the page * fix: propInfo definition * fix: last rent condition * feat: add estimation for property with not fully rented history * feat: get fully rented APR * apply max APR method * rename variable and functions * feat: add RWA token * feat: re-enable property onClick * feat: add rwa valuation on the rwa card * fix: missing property * feat: add rwa to summary card * define useRWA * take into account user currency * feat: add RWA value to net value calculation * remove comment * refactor: clean imports * feat: include RWA on Ethereum * fix: en communs * feat: update filter to support RWA token * fix: prettier * fix: other prettier errors * let prettier add strange semi-column * fix: imports * use hook * add fallback * switch for a useMemo * feat: add real time fully rented APR * feat: add gloabl metric fully rented APR * feat: add disclaimer * feat: add disclaimer * feat: update disclaimer message * fix: disclaimer message * improve message * feat: create yam statics stics page * feat: add yam statistics for all RealT Tokens on Gnosis (who have Gnosis chain contract prop) * feat: mask tokens with no volume * fix: add token name * feat: add pagination * feat: improve style * feat: change token per page to 100 * feat: add fully rented APR to asset grid * refactor: remove logs * feat: add fully rented APR to property details * fix: reset current page when tokens changed * fix: reset current page when user change page size * feat: add translation for YAM statistics hearder label * fix: yamStatistics: use selected currency for token price * feat: yamStatistics: add owned | all filter * feat: yamStatistics: add subsidized, fullySubsidized and notSubsidized filters * add additional fallbacks RPC URLs * fix: RPC initialization on currencies file * feat: YamStatistic: add Yamp Volume's number of days * fix: fullyRentedAPR: fix french disclaimer text * fix: second disclaimer text small error * feat: fullyRentedAPR: manage VEFA properties * refactore: improve comment * feat: show VEFA properties forced fully rented APR only if property do not have tenants * fix: RWA table view * feat: add bridge link on header (#74) * fix: VEFA Realtime APR --------- Co-authored-by: Nandy Bâ <[email protected]> Co-authored-by: Yohann Durand <[email protected]> * Revert "merge preprod <> master (#77)" This reverts commit 68daad5. * fix: APY fully rented for properties before start rent day (#85) Co-authored-by: alex <[email protected]> * Change NS for RealToken (#89) (#90) --------- Co-authored-by: Sigri <[email protected]> Co-authored-by: Kurtisone <[email protected]> Co-authored-by: jycssu-com <[email protected]> Co-authored-by: alex <[email protected]> Co-authored-by: Jycssu <[email protected]> Co-authored-by: Yohann Durand <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sigri <[email protected]> Co-authored-by: Jycssu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: BenoistP <[email protected]> Co-authored-by: Kurtisone <[email protected]> Co-authored-by: jycssu-com <[email protected]> Co-authored-by: alex <[email protected]> Co-authored-by: Yohann Durand <[email protected]>

* Change NS for RealToken (#89) * chore: install required sharp dependency for production * chore(deps): bump body-parser from 1.20.2 to 1.20.3 (#87) Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.2...1.20.3) --- updated-dependencies: - dependency-name: body-parser dependency-type: indirect ... * feat: add new assets REG, REG Vote Power (#91) * first version : Assets as rows * 'other' assets display switch; 'other' assets shown in Summary 'other' assets = tokens others than RealTokens = RWA, REG, ... - Display switch for hiding 'other' assets in table rows - 'other' assets figures added to Summary section * contracts utils * use contract utils for fetching balances * Eth provider removed: REG Voting Power is not deployed on Eth * batchCallOneFunction not fully tested * error args * comments * wrong 'inheritance' * smol fix: properly throw 'User not found' error * style/comments * settings labels and icons * unitIcon: optional + alignment with other units * Filter 'other' assets in Grid view * Settings: switch icons, section names * fix: lint warning * fix: lint warning * fix: build error ? * fix: build error #2 ? * fix: build error #3 ? * fix: build error #4 ? * fix: build error #5 ? * Fix: existing filter error when filtering on "Owned on" * fix: avoid fetching others assets balances if user wallet was not set * feat: add other token price on cards and fix decimals rounds for total invest * fix: improve subsudy filter for exclude other realtokens * fix: fix last changes filter and use correct typing in filters for avoid futurs errors * feat: set initial launch date for RWA token * feat: initialize rpc provider only once * feat: include reg tokens locked inside the incentive vault * fix: fix eslint warnings and add missing translations * Update .gitignore exclude pnpm lockfile * Create .nvmrc add .nvmrc for switching between node versions * Update contract.ts optional parameters for customizing batch calls: batch max and min size, number of attempts before giving up * Regvotingpower: icon orange, size grows depending on amount * unused import * Usdc currency/rate * Voting power size & fill color depending on power amount * Voting power size & fill color depending on power amount * Fixes: token prices in USD, avoid fetching REG vault balances on Eth - Tokens values fix: Updated assets prices by using currenciesRates and user currency rate (previously considering usdc = usd and xdai = usd as well), now assets prices are converted from their respective currencies (e.g. usdc, xdai) to usd, then total value is priced in user choosen currency. - Smol fix: getAddressesLockedBalances was fetching vault balances on Eth, throwing errors as there is not such vault on Eth. Added parameters for fetching any number of vault by provider(s). * comment * Check Providers ability to handle requests - Check Providers ability to handle requests - Additionnal providers https://rpc.ankr.com/eth and https://eth-pokt.nodies.app currently fail to handle concurrent requests * Assets hooks moved in index for avoiding duplicate requests - Both SummaryCard and AssetsView use the same hooks for getting their data, leading to duplicate web3 requests Moving hooks in parent components prevents this form happening. * prettier * Avoid divide by zero in case asset.totalUnits is unknown/zero * "Clean" scripts * Assets filtering moved to the right place filter has to be in assetsView/AssetsView.tsx * Paging translation labels: placeholder, All * simplify pageSize handling * Assets filtering fix (causing pagination issues) OtherAssets filtering was improperly implemented into the map loops by skipping non "others assets" value, causing holes in display (missing cards). Filtering is now done in AssetsView where it should have been in the first place * Revert changes: realtime/global labels for rents calculation switch --------- * fix: API URLs issue #97 (#98) * addresses issue #97 Moves api urls to (.)ENV set utls to new api.realtoken.community domain (previously api.realt.community) * Update .env.sample missing update of sample .env * Update .env.sample * NEXT_PUBLIC_ prefix removed for REALTOKENAPI ENV vars * feat: update yarn lock (#99) * feat: add new API urls to deployment workflow (#100) * feat: pass new env variables to docker env (#101) * fix: unchecked asset filters (#95) * merge master in develop (#103) * Revert "Master" * merge preprod <> master (#67) * add dropdown * simplify selector and add all token option * feat: change allPage value to Infinity * feat: estimate the fully rented rent * feat: add fully rented estimation to asset cards * refactor: move hook calls to top of the page * fix: propInfo definition * fix: last rent condition * feat: add estimation for property with not fully rented history * feat: get fully rented APR * apply max APR method * rename variable and functions * feat: add RWA token * feat: re-enable property onClick * feat: add rwa valuation on the rwa card * fix: missing property * feat: add rwa to summary card * define useRWA * take into account user currency * feat: add RWA value to net value calculation * remove comment * refactor: clean imports * feat: include RWA on Ethereum * fix: en communs * feat: update filter to support RWA token * fix: prettier * fix: other prettier errors * let prettier add strange semi-column * fix: imports * use hook * add fallback * switch for a useMemo * feat: add real time fully rented APR * feat: add gloabl metric fully rented APR * feat: add disclaimer * feat: add disclaimer * feat: update disclaimer message * fix: disclaimer message * improve message * feat: create yam statics stics page * feat: add yam statistics for all RealT Tokens on Gnosis (who have Gnosis chain contract prop) * feat: mask tokens with no volume * fix: add token name * feat: add pagination * feat: improve style * feat: change token per page to 100 * feat: add fully rented APR to asset grid * refactor: remove logs * feat: add fully rented APR to property details * fix: reset current page when tokens changed * fix: reset current page when user change page size * feat: add translation for YAM statistics hearder label * fix: yamStatistics: use selected currency for token price * feat: yamStatistics: add owned | all filter * feat: yamStatistics: add subsidized, fullySubsidized and notSubsidized filters * add additional fallbacks RPC URLs * fix: RPC initialization on currencies file --------- * merge preprod <> master (#77) * add dropdown * simplify selector and add all token option * feat: change allPage value to Infinity * feat: estimate the fully rented rent * feat: add fully rented estimation to asset cards * refactor: move hook calls to top of the page * fix: propInfo definition * fix: last rent condition * feat: add estimation for property with not fully rented history * feat: get fully rented APR * apply max APR method * rename variable and functions * feat: add RWA token * feat: re-enable property onClick * feat: add rwa valuation on the rwa card * fix: missing property * feat: add rwa to summary card * define useRWA * take into account user currency * feat: add RWA value to net value calculation * remove comment * refactor: clean imports * feat: include RWA on Ethereum * fix: en communs * feat: update filter to support RWA token * fix: prettier * fix: other prettier errors * let prettier add strange semi-column * fix: imports * use hook * add fallback * switch for a useMemo * feat: add real time fully rented APR * feat: add gloabl metric fully rented APR * feat: add disclaimer * feat: add disclaimer * feat: update disclaimer message * fix: disclaimer message * improve message * feat: create yam statics stics page * feat: add yam statistics for all RealT Tokens on Gnosis (who have Gnosis chain contract prop) * feat: mask tokens with no volume * fix: add token name * feat: add pagination * feat: improve style * feat: change token per page to 100 * feat: add fully rented APR to asset grid * refactor: remove logs * feat: add fully rented APR to property details * fix: reset current page when tokens changed * fix: reset current page when user change page size * feat: add translation for YAM statistics hearder label * fix: yamStatistics: use selected currency for token price * feat: yamStatistics: add owned | all filter * feat: yamStatistics: add subsidized, fullySubsidized and notSubsidized filters * add additional fallbacks RPC URLs * fix: RPC initialization on currencies file * feat: YamStatistic: add Yamp Volume's number of days * fix: fullyRentedAPR: fix french disclaimer text * fix: second disclaimer text small error * feat: fullyRentedAPR: manage VEFA properties * refactore: improve comment * feat: show VEFA properties forced fully rented APR only if property do not have tenants * fix: RWA table view * feat: add bridge link on header (#74) * fix: VEFA Realtime APR --------- * Revert "merge preprod <> master (#77)" This reverts commit 68daad5. * fix: APY fully rented for properties before start rent day (#85) * Change NS for RealToken (#89) (#90) --------- --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Sigri <[email protected]> Co-authored-by: Jycssu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: BenoistP <[email protected]> Co-authored-by: Kurtisone <[email protected]> Co-authored-by: jycssu-com <[email protected]> Co-authored-by: alex <[email protected]> Co-authored-by: Yohann Durand <[email protected]>

BenoistP added 18 commits November 4, 2024 16:42

first version : Assets as rows

40b09cc

'other' assets display switch; 'other' assets shown in Summary

7ee0e13

'other' assets = tokens others than RealTokens = RWA, REG, ... - Display switch for hiding 'other' assets in table rows - 'other' assets figures added to Summary section

contracts utils

9584517

use contract utils for fetching balances

3810cd9

Eth provider removed: REG Voting Power is not deployed on Eth

67358f5

batchCallOneFunction

4cc6332

not fully tested

error args

76f4e62

comments

bf901a1

wrong 'inheritance'

c100ffe

smol fix: properly throw 'User not found' error

268fce6

style/comments

2eb182f

settings labels and icons

0c67b88

unitIcon: optional + alignment with other units

e5c6a80

Filter 'other' assets in Grid view

b89c466

Settings: switch icons, section names

861e1f7

fix: lint warning

511a1c8

fix: lint warning

a9d683d

fix: build error ?

d6cd7af

BenoistP marked this pull request as ready for review November 5, 2024 18:31

BenoistP added 5 commits November 5, 2024 19:41

fix: build error #2 ?

8865187

fix: build error #3 ?

614ade4

fix: build error #4 ?

edebeac

fix: build error #5 ?

5905089

Fix: existing filter error when filtering on "Owned on"

f7eebab

BenoistP requested a review from NandyBa November 6, 2024 09:29

fix: avoid fetching others assets balances if user wallet was not set

048e1c8

jycssu-com added 3 commits November 9, 2024 11:44

feat: add other token price on cards and fix decimals rounds for tota…

1dce996

…l invest

fix: improve subsudy filter for exclude other realtokens

dfb81f4

fix: fix last changes filter and use correct typing in filters for av…

911c5c9

…oid futurs errors

BenoistP added 2 commits December 3, 2024 19:00

comment

56fd763

Check Providers ability to handle requests

4171429

- Check Providers ability to handle requests - Additionnal providers https://rpc.ankr.com/eth and https://eth-pokt.nodies.app currently fail to handle concurrent requests

BenoistP requested a review from NandyBa December 4, 2024 16:22

Assets hooks moved in index for avoiding duplicate requests

ca89729

- Both SummaryCard and AssetsView use the same hooks for getting their data, leading to duplicate web3 requests Moving hooks in parent components prevents this form happening.

prettier

af0e0a8

NandyBa requested changes Dec 12, 2024

View reviewed changes

src/components/assetsView/filters/AssetsViewSort.tsx Outdated Show resolved Hide resolved

NandyBa reviewed Dec 12, 2024

View reviewed changes

src/utils/blockchain/regVault.ts Show resolved Hide resolved

Avoid divide by zero in case asset.totalUnits is unknown/zero

b6e0b40

BenoistP requested a review from NandyBa December 12, 2024 17:43

NandyBa reviewed Dec 13, 2024

View reviewed changes

BenoistP added 2 commits December 13, 2024 13:00

"Clean" scripts

7319aaf

Assets filtering moved to the right place

ddf7dd5

filter has to be in assetsView/AssetsView.tsx

BenoistP requested a review from NandyBa December 13, 2024 18:24

NandyBa reviewed Dec 13, 2024

View reviewed changes

BenoistP added 3 commits December 13, 2024 23:16

Paging translation labels: placeholder, All

469c0c9

simplify pageSize handling

4a052b4

Assets filtering fix (causing pagination issues)

b2642a3

OtherAssets filtering was improperly implemented into the map loops by skipping non "others assets" value, causing holes in display (missing cards). Filtering is now done in AssetsView where it should have been in the first place

NandyBa requested changes Dec 14, 2024

View reviewed changes

src/i18next/locales/en/common.json Outdated Show resolved Hide resolved

NandyBa reviewed Dec 14, 2024

View reviewed changes

Revert changes: realtime/global labels for rents calculation switch

3e250d3

NandyBa approved these changes Dec 17, 2024

View reviewed changes

NandyBa merged commit 81848e4 into develop Dec 17, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: new assets REG, REG Vote Power, RWA realtime price, Settings updates #91

Feature: new assets REG, REG Vote Power, RWA realtime price, Settings updates #91

BenoistP commented Nov 5, 2024 •

edited by NandyBa

Loading

jycssu-com commented Nov 7, 2024

BenoistP commented Dec 4, 2024

BenoistP commented Dec 6, 2024

NandyBa left a comment

BenoistP commented Dec 13, 2024 •

edited

Loading

NandyBa left a comment •

edited

Loading

BenoistP commented Dec 13, 2024

NandyBa Dec 14, 2024

NandyBa Dec 14, 2024

BenoistP Dec 15, 2024

NandyBa Dec 15, 2024

BenoistP Dec 17, 2024

Sigri44 commented Dec 15, 2024

NandyBa commented Dec 15, 2024 •

edited

Loading

NandyBa left a comment

Feature: new assets REG, REG Vote Power, RWA realtime price, Settings updates #91

Feature: new assets REG, REG Vote Power, RWA realtime price, Settings updates #91

Conversation

BenoistP commented Nov 5, 2024 • edited by NandyBa Loading

jycssu-com commented Nov 7, 2024

BenoistP commented Dec 4, 2024

BenoistP commented Dec 6, 2024

NandyBa left a comment

Choose a reason for hiding this comment

BenoistP commented Dec 13, 2024 • edited Loading

NandyBa left a comment • edited Loading

Choose a reason for hiding this comment

BenoistP commented Dec 13, 2024

NandyBa Dec 14, 2024

Choose a reason for hiding this comment

NandyBa Dec 14, 2024

Choose a reason for hiding this comment

BenoistP Dec 15, 2024

Choose a reason for hiding this comment

NandyBa Dec 15, 2024

Choose a reason for hiding this comment

BenoistP Dec 17, 2024

Choose a reason for hiding this comment

Sigri44 commented Dec 15, 2024

NandyBa commented Dec 15, 2024 • edited Loading

NandyBa left a comment

Choose a reason for hiding this comment

BenoistP commented Nov 5, 2024 •

edited by NandyBa

Loading

BenoistP commented Dec 13, 2024 •

edited

Loading

NandyBa left a comment •

edited

Loading

NandyBa commented Dec 15, 2024 •

edited

Loading