Some fixes #88

deepend-tildeclub · 2024-01-22T03:26:37Z

I know I'm not the best at handling git stuff.. I've been just going page by page trying to reduce errors and issues.. Restored some functionality that wasn't working like private messages, managing and editing world clocks without error, Some fixes to reduce issues with creating polls.(poll stuff not completely working yet) More to come soon. If you like I will request a pull request for future changes as well. I'm not going to pretend to be an expert but I really want this application to function fully and then can always take it further after that if you like.

error reduction mode.

the previous change broke being able to name categories.

Fixes some fatal errors relating to the bindparams function. And Also keeps the naming of categories working properly.

error reduction mode.

RedDragonWebDesign · 2024-01-22T11:48:35Z

Has this stuff been broken for a long time, or do you think it was a PHP version thing? What PHP version are you using?

RedDragonWebDesign · 2024-01-22T11:49:44Z

Usually when you submit a pull request, you will want to create a new branch in git rather than using the master branch. This gives you the ability to submit multiple PRs at the same time just by changing branches. If you use the master branch for all of them, things get messy. No need to change anything for this PR, but a good tip for future PRs.

RedDragonWebDesign · 2024-01-22T11:53:13Z

In the future, will probably want to split into one PR per feature you worked on. For example, one for private messages, one for world clocks, one for polls. This makes it easier for the reviewer to load it up and test it and reason about it :)

deepend-tildeclub · 2024-01-22T15:35:03Z

Has this stuff been broken for a long time, or do you think it was a PHP version thing? What PHP version are you using?

I haven't had any luck getting a ton of this stuff working in the past. Still want to figure out all the issues relating to the download system.. It really doesn't seem to function properly. Only recently found time to work on rebuilding my site. Some of the depreciated stuff is probably due to PHP version. The server its on is currently using PHP 8.1.20

deepend-tildeclub · 2024-01-22T15:35:34Z

In the future, will probably want to split into one PR per feature you worked on. For example, one for private messages, one for world clocks, one for polls. This makes it easier for the reviewer to load it up and test it and reason about it :)

I will work on doing that in the future, sorry about that.

RedDragonWebDesign · 2024-01-22T19:46:00Z

src/classes/btbbcode.php

@@ -58,8 +58,6 @@ public function parse($strText) {
 			}
 			else {
 				$strText = preg_replace(
-			}


Did you mean to remove this brace? Looks like a syntax error.

Actually, looking at more commits, the brace is still there, but is indented too much. And also preg_replace( is missing a );.

Since this is a syntax error from before you started this patch, I would just comment out $strText by adding // to the front of it.

RedDragonWebDesign · 2024-01-22T20:05:23Z

src/_functions.php

-	$strText = preg_replace("/\[\youtube\](http|https)(\:\/\/youtu\.be\/)(.*)\[\/youtube\]/i", "<iframe class='youtubeEmbed' src='http://www.youtube.com/embed/$3?wmode=opaque' frameborder='0' allowfullscreen></iframe>", $strText);
-
-	$strText = str_replace("[/twitch]", "[/twitch]\n", $strText);
+$strText = preg_replace("/\[youtube\](http|https)(\\:\\/\\/www\\.youtube\\.com\\/watch\\?v\\=)(.*)\[\/youtube\]/i", "<iframe class='youtubeEmbed' src='http://www.youtube.com/embed/$3?wmode=opaque' frameborder='0' allowfullscreen></iframe>", $strText);


Please put the old indentation on these lines back. And in the rest of the files please.

On a lot of the lines, you unindented so that the indentation doesn't match the rest of the file. It also makes the git diffs harder to read.

Please use tabs instead of 4 spaces, to match the rest of this repo.

In a good code editor such as VS Code, you can select all the lines you want to indent, then hit tab as many times as needed, and it will scoot them all over to the right.

You can change from 4 spaces to tabs by clicking at the bottom right of VS Code where it says "Tab Size", and click on "Convert Indentation to Tabs"

RedDragonWebDesign · 2024-01-22T20:05:48Z

src/classes/basic.php

-			$sqlValues = rtrim(str_repeat("?, ", count($arrColumns)),", ");
-
-		}
+public function addNew($arrColumns, $arrValues) {


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:06:05Z

src/classes/basicorder.php

-
-		if($intOrderNumID == "first") {
-			// "(no other categories)" selected, check to see if there are actually no other categories
+function validateOrder($intOrderNumID, $strBeforeAfter, $blnEdit = false, $intEditOrderNum = "") {


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:06:33Z

src/classes/btbbcode.php

@@ -58,8 +58,6 @@ public function parse($strText) {
 			}
 			else {
 				$strText = preg_replace(
-			}


Since this is a syntax error from before you started this patch, I would just comment out $strText by adding // to the front of it.

RedDragonWebDesign · 2024-01-22T20:06:51Z

src/classes/btmysql.php

-
-	}
-
+public function bindParams($objMySQLiStmt, $arrValues) {


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:06:57Z

src/classes/form.php

-								<textarea name='".$componentName."' ".$dispAttributes.">".($componentInfo['value'] ?? '')."</textarea>
-							</div>
-						";
+// Output input


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:09:14Z

src/members/include/polls/createpoll.php

-		$arrPostSelected['multivote'] = ($_POST['multivote'] == 1) ? " checked" : "";
-		$arrPostSelected['displayvoters'] = ($_POST['displayvoters'] == 1) ? " checked" : "";
-
+if ($countErrors > 0) {


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:12:57Z

src/members/include/polls/createpoll.php

@@ -178,7 +177,7 @@

 		";

-	
+}


Is this a typo? If not, then the indentation of the code below it should be reduced.

RedDragonWebDesign · 2024-01-22T20:14:04Z

src/members/include/polls/include/addoption.php

-		echo "
-			</table>
-		";
+if (count($_SESSION['btPollOptionCache'][$pollObj->cacheID]) > 0) {


Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:14:17Z

src/members/include/privatemessages/addfolder.php

Please fix indenting.

RedDragonWebDesign · 2024-01-22T20:14:49Z

src/members/privatemessages/compose.php

-			"sortorder" => $i++,
-			"value" => $_POST['subject']
-		),
+        "subject" => array(


Please fix indenting.

Not sure why its moving the { to the next line. I assume its supposed to be this way not with the { on the line below the function line.

managemenu/_functions: fix globals

RedDragonWebDesign · 2024-01-23T05:38:47Z

.idea/.gitignore

@@ -0,0 +1,8 @@
+# Default ignored files


Probably shouldn't have code editor settings files committed to the git repo. The proper way to fix this is...

cut these files into a file outside the repo (to temporarily get them out of the repo, we'll put them back later)

commit the file deletions in git (git commit)

create a global .gitignore file with the contents /.idea/ (how to create a global .gitignore: https://stackoverflow.com/a/7335487)

cut and paste the files back to their original spot

Yeah sorry.. never used this program before.. Didn't know it'd do that. Thanks for your patience with me and the help with great explanations. I usually use a text editor like nano instead. But figure I should probably try something more capable.

RedDragonWebDesign · 2024-01-23T05:38:52Z

src/_functions.php

- * License: http://www.bluethrust.com/license.php
- *
- */
+	/*


Indentation is wrong. Needs un-indenting.

RedDragonWebDesign · 2024-01-23T05:39:20Z

src/classes/access.php

- * License: http://www.bluethrust.com/license.php
- *
- */
+	/*


Indentation is wrong. Needs un-indenting.

RedDragonWebDesign · 2024-01-23T05:39:49Z

src/classes/basic.php

-		if(!$numericIDOnly) {
-			$intIDNum = $this->MySQL->real_escape_string($intIDNum);
-			$checkID = true;
+	/*


Indentation is wrong. Needs un-indenting.

RedDragonWebDesign · 2024-01-23T05:40:10Z

src/classes/basicorder.php

-	 * - selectByOrder Method -
-	 *
-	 *   Way to select a rank by ordernum.  Essentially the same as the normal select method from basic except using the ordernum.
+	/*


Indentation is wrong. Needs un-indenting.

RedDragonWebDesign · 2024-01-23T05:47:51Z

This PR is getting too big. Please don't add any more files to it. Please instead start using git branches as mentioned above, then submit new PRs for groups of files/changes that make sense to group together. Some examples of reasonable groupings:

fix world clocks
fix private messages
fix polls
fix PHP 8.1 deprecations/notices/warnings in X folder/file

To create a new git branch...

git checkout master - makes sure you're on the master branch, to use it as your "base"
git branch fix-world-clocks - creates a new branch called fix-world-clocks. you should pick a name that describes the changes you're about to make.
git checkout fix-world-clocks
make your code changes
save your files
git commit
git push
visit https://github.com/RedDragonWebDesign/BlueThrust5
click the green "Create pull request" button at the top

Rinse and repeat.

Each branch is a snapshot of the file contents at a certain point in time. So if you type git checkout master after making the above changes, it will change your local files to match the master branch. Your changes to fix-world-clocks will be temporarily gone from your local files, but will still be saved in git's memory. This allows us to make a bunch of little forks of the master branch, which is useful for PRs.

deepend-tildeclub · 2024-01-23T06:10:52Z

This PR is getting too big. Please don't add any more files to it. Please instead start using git branches as mentioned above, then submit new PRs for groups of files/changes that make sense to group together. Some examples of reasonable groupings:
* fix world clocks

* fix private messages

* fix polls

* fix PHP 8.1 deprecations/notices/warnings in X folder/file
To create a new git branch...
* `git checkout master` - makes sure you're on the master branch, to use it as your "base"

* `git branch fix-world-clocks` - creates a new branch called fix-world-clocks. you should pick a name that describes the changes you're about to make.

* `git checkout fix-world-clocks`

* make your code changes

* save your files

* `git commit`

* `git push`

* visit https://github.com/RedDragonWebDesign/BlueThrust5

* click the green "Create pull request" button at the top
Rinse and repeat.

Each branch is a snapshot of the file contents at a certain point in time. So if you type git checkout master after making the above changes, it will change your local files to match the master branch. Your changes to fix-world-clocks will be temporarily gone from your local files, but will still be saved in git's memory. This allows us to make a bunch of little forks of the master branch, which is useful for PRs.

I can definitely do that. If you like we can just close this PR and I'll resubmit once I've sorted all this out?

RedDragonWebDesign · 2024-01-23T06:11:49Z

Sure. That will be a lot of work, but if you're willing, that is definitely the most organized way to do it.

deepend-tildeclub · 2024-01-23T06:12:28Z

Sure. That will be a lot of work, but if you're willing, that is definitely the most organized way to do it.

I can try my best.

deepend-tildeclub added 30 commits January 20, 2024 06:53

Update include_header.php

63c4c9d

Update member.php

df7c871

Update member.php

4ee945d

Update recent.php

69fa57e

error reduction mode.

Update unread.php

eedb2e3

error reduction mode.

Update _functions.php

f17dc48

error reduction mode.

Update btmysql.php

1a2e5fc

error reduction mode.

Update access.php

713622a

error reduction mode.

Update basic.php

95e3044

error reduction mode.

Update basicorder.php

959e345

error reduction mode.

Update member.php

bebb50e

error reduction mode.

Update pmfolder.php

a20a696

Update privatemessage.php

64512ab

error reduction mode.

Update rank.php

7d77bc2

error reduction mode.

Update console.managelist.list.php

fca3f08

error reduction mode.

Update console.managelist.php

ad9475f

error reduction mode.

Update compose.php

50560bb

error reduction mode.

Update createpoll.php

608a51a

error reduction mode.

Update addoption.php

6e7df21

error reduction mode.

Update addfolder.php

9d06e22

error reduction mode.

Update manageclocks.php

4eafa17

error reduction mode.

Update manage.php

b8c3a73

error reduction mode.

Update form.php

3218b2b

error reduction mode.

Update btmysql.php

affe7ab

the previous change broke being able to name categories.

Update btmysql.php

497074e

Fixes some fatal errors relating to the bindparams function. And Also keeps the naming of categories working properly.

Update basic.php

d38bd8d

error reduction mode.

Update form.php

19a3db5

error reduction mode.

Update _functions.php

536ad47

error reduction mode.

Update form.php

fbf79b6

error reduction mode.

Update news.php

91e5d06

error reduction mode.

deepend-tildeclub added 2 commits January 21, 2024 20:17

Update member.php

8fa2a8e

error reduction mode.

Update sitesettings_submit.php

42efc0a

error reduction mode.

deepend-tildeclub added 2 commits January 22, 2024 12:18

Update btbbcode.php

267531d

Update btbbcode.php

e4c425a

RedDragonWebDesign requested changes Jan 22, 2024

View reviewed changes

RedDragonWebDesign reviewed Jan 22, 2024

View reviewed changes

RedDragonWebDesign requested changes Jan 22, 2024

View reviewed changes

deepend-tildeclub and others added 5 commits January 22, 2024 14:48

Update basicorder.php

bd48c10

Update basicorder.php

f92fe7c

Not sure why its moving the { to the next line. I assume its supposed to be this way not with the { on the line below the function line.

Indentation and other items.

c3f11d3

Merge pull request #1 from RedDragonWebDesign/master

e237c00

managemenu/_functions: fix globals

Merge remote-tracking branch 'origin/master'

91e3cd8

deepend-tildeclub requested a review from RedDragonWebDesign January 23, 2024 05:39

RedDragonWebDesign requested changes Jan 23, 2024

View reviewed changes

deepend-tildeclub added 2 commits January 22, 2024 23:06

added /.idea/ to .gitignore

c6ebe8d

remove .idea files

f07c6fb

deepend-tildeclub closed this Jan 23, 2024

deepend-tildeclub mentioned this pull request Jan 31, 2024

delete btbbcode.php #138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some fixes #88

Some fixes #88

deepend-tildeclub commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

deepend-tildeclub commented Jan 22, 2024

deepend-tildeclub commented Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 22, 2024

RedDragonWebDesign Jan 23, 2024 •

edited

Loading

deepend-tildeclub Jan 23, 2024

RedDragonWebDesign Jan 23, 2024

RedDragonWebDesign Jan 23, 2024

RedDragonWebDesign Jan 23, 2024

RedDragonWebDesign Jan 23, 2024

RedDragonWebDesign commented Jan 23, 2024 •

edited

Loading

deepend-tildeclub commented Jan 23, 2024

RedDragonWebDesign commented Jan 23, 2024

deepend-tildeclub commented Jan 23, 2024

Some fixes #88

Some fixes #88

Conversation

deepend-tildeclub commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

RedDragonWebDesign commented Jan 22, 2024

deepend-tildeclub commented Jan 22, 2024

deepend-tildeclub commented Jan 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedDragonWebDesign Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RedDragonWebDesign commented Jan 23, 2024 • edited Loading

deepend-tildeclub commented Jan 23, 2024

RedDragonWebDesign commented Jan 23, 2024

deepend-tildeclub commented Jan 23, 2024

RedDragonWebDesign Jan 23, 2024 •

edited

Loading

RedDragonWebDesign commented Jan 23, 2024 •

edited

Loading