Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forum #90

Conversation

deepend-tildeclub
Copy link
Contributor

Fixes related to the forum. I am trying my best to separate these. It'll be better in the future.

@RedDragonWebDesign
Copy link
Owner

These are indented too much. Most lines need to go to the left by one tab.

You can see this tab stuff more easily by clicking on the "Files changed" tab in this GitHub PR. You'll notice the diff is very busy, with almost every line having a change. That is because of the tab changes on every line.

A busy diff makes it hard to see what actually changed, which makes it hard to review.

You can update this PR by checking out its branch (git checkout fix-forum), making your changes, saving, committing, and pushing.

Thanks for all your work on this. I hope you don't mind my detailed comments. I figure if I can teach you to do this the standard way, then it will pay off in the long run, upskilling your ability to contribute code to this repo and others.

@RedDragonWebDesign RedDragonWebDesign mentioned this pull request Jan 23, 2024
@deepend-tildeclub deepend-tildeclub deleted the fix-forum branch January 23, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants